Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76DE2128CF2 for ; Tue, 5 Feb 2019 16:55:04 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -12.553 X-Spam-Level: X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BoON49xvQPyb for ; Tue, 5 Feb 2019 16:55:02 -0800 (PST) Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69A61128B01 for ; Tue, 5 Feb 2019 16:55:02 -0800 (PST) Date: Tue, 05 Feb 2019 16:55:01 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549414501; bh=NyWQLiC/HSDvUufbJNluMDtp3AeN0o8lYNdguAajvJo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Rl5ZNXAtH4AZe8WYuvvU3s28VGpScl1E8ffk71w7c4D3gLBiLDN4IU77nR3oYt7SW VBZsRQqHHiEA1JhH7qXhKgIzP206Pq6Q+ipidpkX1s5EVv6yDD4Lj9M0TTXyT4DTxU 4yGHgCc7CRL3CV9GGIV3u7wlJf14OIAiGzOEt7bM= From: Martin Thomson Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Servers can still CANCEL, too. (#2426) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a3065ae117_6eb13fc5cf0d45c41136dd"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: martinthomson X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 00:55:04 -0000 ----==_mimepart_5c5a3065ae117_6eb13fc5cf0d45c41136dd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit martinthomson commented on this pull request. > @@ -1382,7 +1386,7 @@ HTTP_PUSH_ALREADY_IN_CACHE (0x04): : The server has attempted to push content which the client has cached. HTTP_REQUEST_CANCELLED (0x05): -: The client no longer needs the requested data. +: The sender is no longer processing the request or response. Not sure if you want to use "processing" here. It might be read as implying something more (REQUEST_REJECTED). Maybe: ```suggestion : The request or its response is cancelled. ``` > @@ -1004,11 +1004,15 @@ some higher layer of software that might have taken some action as a result. The client can treat requests rejected by the server as though they had never been sent at all, thereby allowing them to be retried later on a new connection. Servers MUST NOT use the HTTP_REQUEST_REJECTED error code for requests which -were partially or fully processed. When a client sends a STOP_SENDING with -HTTP_REQUEST_CANCELLED, a server MAY indicate the error code -HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM if no processing was -performed. Clients MUST NOT reset streams with the HTTP_REQUEST_REJECTED error -code except in response to a QUIC STOP_SENDING frame. +were partially or fully processed. When a server abandons a response after +partial processing, it SHOULD abort its response stream with the error code +HTTP_REQUEST_CANCELLED. + +When a client sends a STOP_SENDING with HTTP_REQUEST_CANCELLED, a server MAY +indicate the error code HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM ```suggestion send the error code HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM ``` > @@ -1004,11 +1004,15 @@ some higher layer of software that might have taken some action as a result. The client can treat requests rejected by the server as though they had never been sent at all, thereby allowing them to be retried later on a new connection. Servers MUST NOT use the HTTP_REQUEST_REJECTED error code for requests which -were partially or fully processed. When a client sends a STOP_SENDING with -HTTP_REQUEST_CANCELLED, a server MAY indicate the error code -HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM if no processing was -performed. Clients MUST NOT reset streams with the HTTP_REQUEST_REJECTED error -code except in response to a QUIC STOP_SENDING frame. +were partially or fully processed. When a server abandons a response after +partial processing, it SHOULD abort its response stream with the error code +HTTP_REQUEST_CANCELLED. + +When a client sends a STOP_SENDING with HTTP_REQUEST_CANCELLED, a server MAY +indicate the error code HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM +if no processing was performed. Clients MUST NOT reset streams with the +HTTP_REQUEST_REJECTED error code except in response to a QUIC STOP_SENDING +frame. ```suggestion frame that contains the same code. ``` The implication here is that a server won't use STOP_SENDING with REQUEST_REJECTED unless they have not processed anything. That's not necessary obvious to me now, having had some time away from this subject. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2426#pullrequestreview-200375441 ----==_mimepart_5c5a3065ae117_6eb13fc5cf0d45c41136dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@martinthomson commented on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-http.md:

=0D 
> @@ -1382,7 +1386,7 @@ HTTP_PUSH_ALREADY_IN=
_CACHE (0x04):=0D
 : The server has attempted to push content which the client has cached.=0D=

 =0D
 HTTP_REQUEST_CANCELLED (0x05):=0D
-: The client no longer needs the requested data.=0D
+: The sender is no longer processing the request or response.=0D
=0D

Not sure if you want to use "processing" here. It might be read as im= plying something more (REQUEST_REJECTED). Maybe:

=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-: The sender is no longer processing the requ=
est or response.=0D
+: The request or its response is cancelled.=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-http.md:

=0D 
> @@ -1004,11 +1004,15 @@ some higher layer =
of software that might have taken some action as a result. The=0D
 client can treat requests rejected by the server as though they had neve=
r been=0D
 sent at all, thereby allowing them to be retried later on a new connecti=
on.=0D
 Servers MUST NOT use the HTTP_REQUEST_REJECTED error code for requests w=
hich=0D
-were partially or fully processed.  When a client sends a STOP_SENDING w=
ith=0D
-HTTP_REQUEST_CANCELLED, a server MAY indicate the error code=0D
-HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM if no processing=
 was=0D
-performed.  Clients MUST NOT reset streams with the HTTP_REQUEST_REJECTE=
D error=0D
-code except in response to a QUIC STOP_SENDING frame.=0D
+were partially or fully processed.  When a server abandons a response af=
ter=0D
+partial processing, it SHOULD abort its response stream with the error c=
ode=0D
+HTTP_REQUEST_CANCELLED.=0D
+=0D
+When a client sends a STOP_SENDING with HTTP_REQUEST_CANCELLED, a server=
 MAY=0D
+indicate the error code HTTP_REQUEST_REJECTED in the corresponding RESET=
_STREAM=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-indicate the error code HTTP_REQUEST_REJECTED=
 in the corresponding RESET_STREAM=0D
+send the error code HTTP_REQUEST_REJECTED in the corresponding RESET_STR=
EAM=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-http.md:

=0D 
> @@ -1004,11 +1004,15 @@ some higher layer =
of software that might have taken some action as a result. The=0D
 client can treat requests rejected by the server as though they had neve=
r been=0D
 sent at all, thereby allowing them to be retried later on a new connecti=
on.=0D
 Servers MUST NOT use the HTTP_REQUEST_REJECTED error code for requests w=
hich=0D
-were partially or fully processed.  When a client sends a STOP_SENDING w=
ith=0D
-HTTP_REQUEST_CANCELLED, a server MAY indicate the error code=0D
-HTTP_REQUEST_REJECTED in the corresponding RESET_STREAM if no processing=
 was=0D
-performed.  Clients MUST NOT reset streams with the HTTP_REQUEST_REJECTE=
D error=0D
-code except in response to a QUIC STOP_SENDING frame.=0D
+were partially or fully processed.  When a server abandons a response af=
ter=0D
+partial processing, it SHOULD abort its response stream with the error c=
ode=0D
+HTTP_REQUEST_CANCELLED.=0D
+=0D
+When a client sends a STOP_SENDING with HTTP_REQUEST_CANCELLED, a server=
 MAY=0D
+indicate the error code HTTP_REQUEST_REJECTED in the corresponding RESET=
_STREAM=0D
+if no processing was performed.  Clients MUST NOT reset streams with the=
=0D
+HTTP_REQUEST_REJECTED error code except in response to a QUIC STOP_SENDI=
NG=0D
+frame.=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-frame.=0D
+frame that contains the same code.=0D
=0D =0D

The implication here is that a server won't use STOP_SENDING with REQU= EST_REJECTED unless they have not processed anything. That's not necessa= ry obvious to me now, having had some time away from this subject.

=0D= =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or mute the thread.

= =0D =0D = ----==_mimepart_5c5a3065ae117_6eb13fc5cf0d45c41136dd--