IETF Logo Mail Archive

Re: [quicwg/base-drafts] Gratuitous change of QHKDF-Expand in draft 10 (#1255)

Patrick McManus <notifications@github.com> Wed, 11 April 2018 23:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1C11812D86D for <quic-issues@ietfa.amsl.com>; Wed, 11 Apr 2018 16:56:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vELLPJ3uz8FY for <quic-issues@ietfa.amsl.com>; Wed, 11 Apr 2018 16:56:29 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4746D12D86A for <quic-issues@ietf.org>; Wed, 11 Apr 2018 16:56:29 -0700 (PDT)
Date: Wed, 11 Apr 2018 16:56:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1523490988; bh=czX3yNyPpnof53nXOSBKOkyBtoAh8XRXH/oMyvW+fv8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CXwtArW2q8vrG/wSH0RNtq0MIDVq/jn9JWNpxZqZdFTGniqSrSrLIb6+hO1ZBNxLY nBRBUD5+E4aqGvdCnTuNzcKDqDQH2WBZ2NljFufwSzyIdv0H0X8Kw5KK3dRKB0ujX3 7ER/UgFizGyKyeHbh8TSMxHgm/4oKLzfJnbSJTQw=
From: Patrick McManus <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf373aeaaf5c18b5e0de6a7a9986471b290ed226d92cf0000000116e662ac92a169ce1272420b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1255/380631557@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1255@github.com>
References: <quicwg/base-drafts/issues/1255@github.com>
Subject: Re: [quicwg/base-drafts] Gratuitous change of QHKDF-Expand in draft 10 (#1255)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5acea0ac6f36d_77e92b0421ee2ec41544ae"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mcmanus
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-7dMbek-3fs5UV74DD9ZS8YXMJg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Apr 2018 23:56:31 -0000

I did it for mozquic/nss too.. except i actually did it from day 1 so the
recent changes were easy.

On Wed, Apr 11, 2018 at 6:56 PM, Kazuho Oku <notifications@github.com>
wrote:

> Reading #1255 <https://github.com/quicwg/base-drafts/issues/1255>
> (comment), I'd assume that the case is similar with NSS, except for the
> fact that NSS does not provide a way to specify BaseLabel other than "tls13
> ".
>
> NSS doesn't export an HKDF wrapper, so anyone who wants to do this rolls
> their own, as Patrick has done.
>
> Sorry for the confusion. Reading #1255 (comment)
> <https://github.com/quicwg/base-drafts/issues/1255#issuecomment-377276565>,
> I assumed that it was NSS. It was minq, actually (#1256 (comment)
> <https://github.com/quicwg/base-drafts/pull/1256#issuecomment-378590889>).
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/issues/1255#issuecomment-380621352>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAP5s7AH8kSYwjew7jdlqYHJriYKb79Dks5tnoongaJpZM4S_ISL>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1255#issuecomment-380631557

v2.46.0 | Report a Bug | By Email | System Status