Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)

ianswett <notifications@github.com> Wed, 19 December 2018 14:21 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CA1812867A for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 06:21:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.065
X-Spam-Level:
X-Spam-Status: No, score=-3.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OB1Aq5bplcCG for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 06:21:56 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E12CD1271FF for <quic-issues@ietf.org>; Wed, 19 Dec 2018 06:21:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=oS1MZvtwO6ecObgpdB7QNMZsNzQ=; b=NiHKtc3xQr4uRyLH N/8eDz8PLhFhuSinaR+dNHlEVBfglomhmX96HC4s0zK5AGbdqu0irFlvLAF0aeg0 TAXSI73M3XUkn3CXplqa9ULcvxpvNUkjezAlaZ6Gwdbx1FcCQ1FnjU873Ne/7iaL qoi7ivzWP8x185cUCaio3GzKQcQ=
Received: by filter0072p1iad2.sendgrid.net with SMTP id filter0072p1iad2-23580-5C1A5401-E 2018-12-19 14:21:53.310822185 +0000 UTC m=+158441.586976582
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0037p1iad2.sendgrid.net (SG) with ESMTP id a-T12rSiQ9CWORIYFO0JhQ for <quic-issues@ietf.org>; Wed, 19 Dec 2018 14:21:53.242 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 4A301814DD for <quic-issues@ietf.org>; Wed, 19 Dec 2018 06:21:53 -0800 (PST)
Date: Wed, 19 Dec 2018 14:21:53 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab983fa54553e5ac816ee79f43ad84c396e9a68bf892cf000000011832160192a169ce1762ed93@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2205/448612503@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2205@github.com>
References: <quicwg/base-drafts/issues/2205@github.com>
Subject: Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1a540148a1d_61a3f9e69ad45c01909ad"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0k+TUnQNOpS7/OvTTRZO6gS9fxbBeWG9/b7Y Xr9a0lnVLg7WNXgNV1vhbxKkNzhWRXB4AGePrIyzNmzurUeFyoA3r9iSsMke2SijgJh5LbPfdnfxNM S807Z3f0CSlvSGBz+mr9hMqYFZjDpPNKG+Hf0mjBLxu8apJdkQoLiniCsg==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-G1XDC9MdKgv6LPgIoKCRREtA6Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 14:21:58 -0000

There are a few things this precludes, and we we should understand those before doing this.

1) A very limited implementation(ie: hardware) can't always send only one ACK block without giving up on reordered packets.  I don't have such an implementation, but at some point I remember discussing this idea with people who seemed interested in it.
2) One cannot do multipath with QUIC v1 and it means the multipath design will have to use a PN space per path, as described in Christian's draft: https://tools.ietf.org/html/draft-huitema-quic-mpath-req-01#section-4.11  I think that's likely the right choice for other reasons, but I'm hesitant to make that decision now.
3) An RTT sample can only be taken based on the largest acked.  Therefore, if there is a large amount of reordering(ie: 1RTT), you don't get any RTT samples for an RTT.  If we care about this, we can probably solve it a different way in the recovery draft, but that likely means using ack delay sometimes and not others.

In regards to Martin's comment, I thought we already had text that said ACKs with lower packet numbers than the largest ACK packet number should be ignored, since they're old?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2205#issuecomment-448612503