IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)

Kazu Yamamoto <notifications@github.com> Wed, 22 July 2020 11:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A71333A0935 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 04:40:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ovoseziar92S for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 04:40:33 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 65EB13A0933 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 04:40:33 -0700 (PDT)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id 445DC6A10AA for <quic-issues@ietf.org>; Wed, 22 Jul 2020 04:40:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595418032; bh=b8dprpTEwyyYQz8jFYzGDf66kPf5S3nAU8z5rX/PGRc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kITLC2/Uon3oxVF0u2IzcJm+vv7OVlQphzOS6yM+fX9iV6HwYPy1t3/Zly2AZCloo 2N25uRE/mdxqpLeKLYPG3q3Ns3GYWsFsDwm3cFwxFNickWgM1L2hzFrDgqQ99hgoGM DIDyCeHajzusA0AkSIxUXbfhEiw6r/mtbcZMi6UI=
Date: Wed, 22 Jul 2020 04:40:32 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2SDUDVYYYKEZN7CLN5EQDLBEVBNHHCPC5BAU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3938/review/453235284@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3938@github.com>
References: <quicwg/base-drafts/pull/3938@github.com>
Subject: Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1825b03350a_27df3f896c6cd95c17942"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-Pw0CHx1cognPjrovRoJpaUHwdo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 11:40:35 -0000

@kazu-yamamoto commented on this pull request.



> @@ -1129,6 +1129,10 @@ follows:
    smoothed_rtt = kInitialRtt
    rttvar = kInitialRtt / 2
    min_rtt = 0
+   // max_ack_delay is initialized to 0 and
+   // updated when transport parameters are exchanged.
+   // If a peer does not specify max_ack_delay,
+   // it is set to 25ms.

My purpose is to make pseudocode consistent with the spec. It seems to me that the spec should be changed if your observation is correct. I'm happy to drop the commit when the spec is changed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3938#discussion_r458729187

v2.23.0 | Report a Bug | By Email