Date: Thu, 14 Jun 2018 17:24:49 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab4533d04e2cd4ae0e5fcddf1a56821f593f48277b92cf00000001173ac95192a169ce13d31ec6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1446/c397477249@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1446@github.com>
References: <quicwg/base-drafts/pull/1446@github.com>
Subject: Re: [quicwg/base-drafts] Grease values in HTTP/QUIC (#1446)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b2307518059f_2ebc2ae287cccf601796";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-SKygvTXc26uGm32mwthZY2zc_I>


----==_mimepart_5b2307518059f_2ebc2ae287cccf601796
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

LGTM.

An observation: we have discussed unidirectional stream type as an extension point. If that PR lands then it would make sense to grease the type byte too. I can live with that being defined in a separate PR if it helps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249
----==_mimepart_5b2307518059f_2ebc2ae287cccf601796
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>LGTM.</p>
<p>An observation: we have discussed unidirectional stream type as an extension point. If that PR lands then it would make sense to grease the type byte too. I can live with that being defined in a separate PR if it helps.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq6D251xbJ4IGijzzYMZSIUeeSR9Tks5t8v7RgaJpZM4Uo1BN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqz7QGypb9llEWMhU6NNedB-70LP7ks5t8v7RgaJpZM4Uo1BN.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249","url":"https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@LPardue in #1446: LGTM.\r\n\r\nAn observation: we have discussed unidirectional stream type as an extension point. If that PR lands then it would make sense to grease the type byte too. I can live with that being defined in a separate PR if it helps."}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Grease values in HTTP/QUIC (#1446)",
"sections": [
{
"text": "",
"activityTitle": "**Lucas Pardue**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@LPardue",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"quicwg/base-drafts\",\n\"issueId\": 1446,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"quicwg/base-drafts\",\n\"pullRequestId\": 1446\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1446#issuecomment-397477249"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346247245\n}"
}
],
"themeColor": "26292E"
}</script>
----==_mimepart_5b2307518059f_2ebc2ae287cccf601796--