IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Mike Bishop <notifications@github.com> Wed, 19 December 2018 20:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C553130ED7 for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 12:29:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1WTh6KqTicqS for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 12:29:33 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 81AB5130EC9 for <quic-issues@ietf.org>; Wed, 19 Dec 2018 12:29:33 -0800 (PST)
Date: Wed, 19 Dec 2018 12:29:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545251372; bh=MXpgfm6dKOoKOpoQGZddFWxNjTGATSXughlbz5jOa1M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=K2mF98lfP55fcE7TPs0cIed7+U+/7GRzNPbBUeOnQF6cgYeCPYlWInIAxY10yVVen KPRhlg0E+03GaMXfJTF7h/fZhxXA0V/tm6lYNmyZMQw6mkgp3TssJ4SUiUesUOLETu NI2BOc+wOVf3z/jaBwrHKDNJXhvme69+LohFJzfA=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab19f0a6b023983d866610df585e07a622fbc9981d92cf0000000118326c2c92a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/186735112@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1aaa2c8a7fa_65573f89d18d45c41476c6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-_MChVavm22Lsds4XCCYdY1ZkNI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 20:29:35 -0000

MikeBishop commented on this pull request.



> @@ -2658,7 +2663,7 @@ level and can only be acknowledged in Handshake packets.
 
 This enforces cryptographic separation between the data sent in the different
 packet sequence number spaces.  Each packet number space starts at packet number
-0.  Subsequent packets sent in the same packet number space MUST increase the
+1.  Subsequent packets sent in the same packet number space MUST increase the

Since this happened again, I reworded the sentence so the line doesn't start with a digit. 🙄

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#discussion_r243064711

v2.14.0 | Report a Bug | By Email