Re: [quicwg/base-drafts] Clarify ACK Delay and reference host-delay (#3971)

Jana Iyengar <notifications@github.com> Thu, 30 July 2020 15:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90DB63A0AA7 for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 08:59:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bdksKCpAlA-J for <quic-issues@ietfa.amsl.com>; Thu, 30 Jul 2020 08:59:20 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0E8123A0A93 for <quic-issues@ietf.org>; Thu, 30 Jul 2020 08:58:40 -0700 (PDT)
Received: from github-lowworker-3a0df0f.ac4-iad.github.net (github-lowworker-3a0df0f.ac4-iad.github.net [10.52.25.92]) by smtp.github.com (Postfix) with ESMTP id 1A0C8840EFA for <quic-issues@ietf.org>; Thu, 30 Jul 2020 08:58:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596124719; bh=Pcur/pGEwBA8m3lX53+8i9RKUzrlovlOqTurKMBWiCY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mu1v7Cv6rV8kK4DwDJ+gfucwho6H+Rt6O1v7/TVKj2PiEahB5M2Q3sZiKK4ywiZWA 44uFnja3GXBdX9XI3BFQ3t96zveBtIkMevkXteh2e938iuOH7KKAKvCYsXmF6sgXKb 8KVhzQvd9E4pI7wkzYQILcbxszQNOdid8Zt5u3zQ=
Date: Thu, 30 Jul 2020 08:58:39 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4RHGQM3R6SDQAEFAN5F3HS7EVBNHHCPTRR6M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3971/review/458540916@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3971@github.com>
References: <quicwg/base-drafts/pull/3971@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ACK Delay and reference host-delay (#3971)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f22ee2fb6c5_1bbb16f8353a7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-cu3c4R57Q_ivem32wPSN9gYQMA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 15:59:23 -0000

@janaiyengar commented on this pull request.



> +: A variable-length integer encoding the intentional delay between when the
+  largest acknowledged packet, as indicated in the Largest Acknowledged field,
+  was received, and when the ACK frame was sent; see {{host-delay}}.
+  The acknowledgement delay in microseconds is the value of the ACK Delay
+  field multiplied by 2 to the power of the ack_delay_exponent transport
+  parameter sent by the sender of the ACK frame;
+  see {{transport-parameter-definitions}}.  Scaling in this fashion allows for
+  a larger range of values with a shorter encoding at the cost of lower
+  resolution.  Because the receiver doesn't use the ACK Delay for Initial and
+  Handshake packets, a sender SHOULD send a value of 0.

```suggestion
: A variable-length integer encoding the acknowledgement delay in
  microseconds; see {{host-delay}}. It is decoded by multiplying the
  value in the field by 2 to the power of the ack_delay_exponent transport
  parameter sent by the sender of the ACK frame; see
  {{transport-parameter-definitions}}.  This encoding allows for a large
  range of values, although it sacrifices some resolution.
  
  Since the acknowledgement delay is not used for Initial and Handshake
  packets, the ACK Delay field in acknowledgements for those packet types
  SHOULD be set to 0.
```

Also, I would move this last paragraph up to the host-delay section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3971#pullrequestreview-458540916