Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Mike Bishop <notifications@github.com> Tue, 18 December 2018 21:32 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B00C130FC2 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 13:32:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.661
X-Spam-Level:
X-Spam-Status: No, score=-1.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lu1cg7GDf8Lw for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 13:32:05 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE29B130F29 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 13:32:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=0xs38kfcG9cIPQ7FfATyxw2YuF0=; b=ptR7tvTaoYCToU3g dPCbgushvPbb42EGYqFG6lHOpcUeWw6cACnIz3oXl05t3nTaGsyQGE74z4FteeTq 5IOs28fluVI3IlC4OqmV80FxGVdE1H2Gs490+qZ7icuzT/nqNMknH3DpArTQdB3x Um5Htr4T+qTi10VlSo9XD4izucU=
Received: by filter1463p1mdw1.sendgrid.net with SMTP id filter1463p1mdw1-9557-5C196753-25 2018-12-18 21:32:03.641264012 +0000 UTC m=+102682.576476248
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0066p1mdw1.sendgrid.net (SG) with ESMTP id DTO1kgV1QIi-QDvAR_qckg for <quic-issues@ietf.org>; Tue, 18 Dec 2018 21:32:03.631 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id 8775C260EE2 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 13:32:03 -0800 (PST)
Date: Tue, 18 Dec 2018 21:32:03 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb767b073acb4023e470617ab30b0229481b5fb3d92cf000000011831295392a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/186291677@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1967537f22b_1fef3fb3080d45bc3230ac"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3i9BPA4bCCCxuB5PN6XoYlQngU6fWpnkebme t/1P7HdMXwpX6XnWTd0Waiqno25SRchhUMcuT5n16fHkJoefa7zZtPgEEiKjRujsHw8sA2w+s2qaIY v6HOrY6aAaMXNXej6RRbIc7NBeSXtvAq/4fsq9XGWp1NlCSsHlyOC14LSykgcGdgTCLMaV/HNcIsah A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-e40A_Gp6zjfOHwyTDA46cceLHc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 21:32:06 -0000

MikeBishop commented on this pull request.



> @@ -2658,7 +2663,7 @@ level and can only be acknowledged in Handshake packets.
 
 This enforces cryptographic separation between the data sent in the different
 packet sequence number spaces.  Each packet number space starts at packet number
-0.  Subsequent packets sent in the same packet number space MUST increase the
+1.  Subsequent packets sent in the same packet number space MUST increase the

Bah, my editor sometimes does this and I don't catch it.  Let me correct that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#discussion_r242713124