IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)

Marten Seemann <notifications@github.com> Sun, 18 March 2018 08:57 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DDB2A12702E for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 01:57:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.626
X-Spam-Level:
X-Spam-Status: No, score=-0.626 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pY44Ok2XqCs8 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 01:57:45 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C142E1200FC for <quic-issues@ietf.org>; Sun, 18 Mar 2018 01:57:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=JpGtal9MghfdiUvs+bsp1mw3QTc=; b=YNcTGbNixfezpiCX kfr+ox/2RYTKMGfy5IDqdvyZoH9qvwuwr5No9bwZg8CpRyjDnIz5vomrVIScBwFN 7mlCxcUcMhuylVUKehtGBpzjrChB0LGAOnhENHOznuZzolSwp12xnKGBtVMqnEvq Fc7It0jn3AfCfmds3AEkVf2vbzc=
Received: by filter0619p1las1.sendgrid.net with SMTP id filter0619p1las1-16245-5AAE2A09-4 2018-03-18 08:57:45.183885278 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0027p1mdw1.sendgrid.net (SG) with ESMTP id zKrWV5DJT8Gti6h-6LlAfg for <quic-issues@ietf.org>; Sun, 18 Mar 2018 08:57:45.067 +0000 (UTC)
Date: Sun, 18 Mar 2018 08:57:45 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab88287f158e2fe1993f9a75d6c6b638e3f3a082d392cf0000000116c5ec0892a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104790072@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae2a08c8e4a_12952af750a00ed480040"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1XcsxgUPNOKfq2THPs8DlBOBNSpT7q2CxcXv 2br8XUEZf91+RWDhg1uffItFruICbx4X6Kb35EvchDb+1ayUIWH0UjA02q0sKYUbrMypSc5T59qHvh ZKDBIHqYgJaDjtwW4c9gWWSd15FhmSI17vae1LHeHfO/+v0Io1jG0CYP0sRwuOUTDslMneZt83RQiR 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-g6FISMzfYKVcTS0nAJbx0WoY58>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 08:57:47 -0000

marten-seemann commented on this pull request.



> @@ -834,19 +834,19 @@ DetectLostPackets(largest_acked):
   foreach (unacked < largest_acked.packet_number):
     time_since_sent = now() - unacked.time_sent
     delta = largest_acked.packet_number - unacked.packet_number
-    if (time_since_sent > delay_until_lost):
-      lost_packets.insert(unacked)
-    else if (delta > reordering_threshold)
+    if (time_since_sent > delay_until_lost ||
+      delta > reordering_threshold):

Isn't that what I did?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1223#discussion_r175281765

v2.27.8 | Report a Bug | By Email | System Status