Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

ianswett <notifications@github.com> Mon, 08 April 2019 13:38 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5EFBB1201B9 for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 06:38:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PiRI5iDTsBLr for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 06:38:32 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD15B120427 for <quic-issues@ietf.org>; Mon, 8 Apr 2019 06:37:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=kOSe3sfKBxCDXurWLyCMhJ4YInw=; b=Ju31AuX8wu+n8QLu I+FquUuJFDTlGbv4jLOh1AHeir7oty0fxDUkUC/Yz3yDXmI3jueK9vAlb5Pb9r4A oSkHy5i2/jXoZUv9zo8P0b8CIaiytuw64/7ojmVFHySQux38YDoTlUdIt3Ow3tP5 /iUfDeQGFRctS9uTmqugWGD53oY=
Received: by filter0151p1iad2.sendgrid.net with SMTP id filter0151p1iad2-23146-5CAB4E89-4B 2019-04-08 13:37:13.912550032 +0000 UTC m=+6761.398054028
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id JbMgYdDPQlOLRuk5EXd49A for <quic-issues@ietf.org>; Mon, 08 Apr 2019 13:37:13.820 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id D4042C02BF for <quic-issues@ietf.org>; Mon, 8 Apr 2019 06:37:13 -0700 (PDT)
Date: Mon, 08 Apr 2019 13:37:13 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdaab5044678541ee06a6733bb6d36c2df4d61d4c92cf0000000118c3108992a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/223847327@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cab4e89d1085_4cc83fcaa0ed45b8114847"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1oRGo722gYcW9DgQpBPuz7waLt812iiXN6Vi x96zoveBf+uw0t6N35ejL1RH0+5qsbO4mUgwLm/QISUICuaG15+Ji1MZ9lVjj/XvC9QJTx9tu9sUE7 CH0yI+qd2YF2pWOje+uQc81nsbPy1JazMwkbKCQf8P32ZfUBvyObwrswwT1qqVuhmdKiG0IkrQL6Eh 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-hedUOlIdukt9b336BP3Nzmadmk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Apr 2019 13:38:36 -0000

ianswett commented on this pull request.



> @@ -458,17 +462,16 @@ sent, then no alarm should be armed until data has been received from the
 client.
 
 Because the server could be blocked until more packets are received, the client
-MUST start the crypto retransmission timer even if there is no unacknowledged
-CRYPTO data.  If the timer expires and the client has no CRYPTO data to
-retransmit and does not have Handshake keys, it SHOULD send an Initial packet in
-a UDP datagram of at least 1200 bytes.  If the client has Handshake keys, it
-SHOULD send a Handshake packet.
-
-On each consecutive expiration of the crypto timer without receiving an
-acknowledgement for a new packet, the sender SHOULD double the crypto
-retransmission timeout and set a timer for this period.
+MUST ensure the crypto retransmission timer is set if there is unacknowledged
+crypto data and MUST ensure the timer is set until it has 1-RTT keys.
+If the timer expires and the client has no CRYPTO data to retransmit and does
+not have Handshake keys, it MUST send an Initial packet in a UDP datagram of
+at least 1200 bytes.  If the client has Handshake keys, it MUST send a

I believe the particular concern is that the client could have Handshake keys because they receive the server's Initial, but not receive the server's Handshake packet, so have nothing to send in Handshake encryption.

If the client ever had CRYPTO data to send in Handshake, then this would not be a concern, as you state.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r273049190