Re: [quicwg/base-drafts] http-core and Friends (#3513)

Mark Nottingham <notifications@github.com> Thu, 12 March 2020 23:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2BF1F3A09AB for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 16:59:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.901
X-Spam-Level: *
X-Spam-Status: No, score=1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_SUMOF=5, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JpRJFKO0yncf for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 16:59:05 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 263243A09AC for <quic-issues@ietf.org>; Thu, 12 Mar 2020 16:59:05 -0700 (PDT)
Received: from github-lowworker-45eca55.ac4-iad.github.net (github-lowworker-45eca55.ac4-iad.github.net [10.52.25.70]) by smtp.github.com (Postfix) with ESMTP id 6AF4D28004F for <quic-issues@ietf.org>; Thu, 12 Mar 2020 16:59:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584057544; bh=q32zZJR/VZDUD5rI/1vKP+CwJiiOcYazCNh219orAWw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sMvYpf11tyMswLEe84WS5hS5VIXreL1+MHzAsZdOnOwrqGLqcGl8GcHyhWTfQ0nmT CcJfaUwxqUF3pQwMkNZ1xa8GlLA5xntggEQx5ldZG8AI41FU88xNf5fCbCAb6EzYW9 c9GtM6GkRu518/ESVjwZ7Ec3NFRbTnsfDaMAnXGU=
Date: Thu, 12 Mar 2020 16:59:04 -0700
From: Mark Nottingham <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYEE3O5YD7FRWLNDPV4O2W4REVBNHHCFCTWBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3513/review/373968241@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3513@github.com>
References: <quicwg/base-drafts/pull/3513@github.com>
Subject: Re: [quicwg/base-drafts] http-core and Friends (#3513)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6accc83f4eb_10853ffcf6acd964518c0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mnot
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-ikOUaHueQcB6P5v79Iy5xegcU0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 23:59:07 -0000

mnot requested changes on this pull request.

I've reviewed the diffs, not the changes in situ.

>  Because HPACK {{?HPACK=RFC7541}} relies on in-order transmission of compressed
-header blocks (a guarantee not provided by QUIC), HTTP/3 replaces HPACK with
+field blocks (a guarantee not provided by QUIC), HTTP/3 replaces HPACK with

"field sections" is the term of art - see https://httpwg.org/http-core/draft-ietf-httpbis-semantics-latest.html#header.fields
```suggestion
field sections (a guarantee not provided by QUIC), HTTP/3 replaces HPACK with
```

>  
 ## Discovering an HTTP/3 Endpoint {#discovery}
 
 An HTTP origin advertises the availability of an equivalent HTTP/3 endpoint via
-the Alt-Svc HTTP response header field or the HTTP/2 ALTSVC frame
+the Alt-Svc HTTP response field or the HTTP/2 ALTSVC frame

AIUI Alt-Svc is a header field, so this is fine either way.

>  
-Just as in previous versions of HTTP, header field names are strings of ASCII
+Just as in previous versions of HTTP, field names are strings of ASCII

Hm. It's not _all_ ASCII characters.

>  characters that are compared in a case-insensitive fashion.  Properties of HTTP
-header field names and values are discussed in more detail in Section 3.2 of
-{{!RFC7230}}, though the wire rendering in HTTP/3 differs.  As in HTTP/2, header
-field names MUST be converted to lowercase prior to their encoding.  A request
-or response containing uppercase header field names MUST be treated as
-malformed ({{malformed}}).
+field names and values are discussed in more detail in Section 4.3 of
+{{!SEMANTICS}}.  As in HTTP/2, field names MUST be converted to lowercase prior
+to their encoding.  A request or response containing uppercase field names MUST

```suggestion
to their encoding.  A request or response containing uppercase characters in field names MUST
```

>  QPACK [QPACK].  QPACK uses separate unidirectional streams to modify and track
-header table state, while header blocks refer to the state of the table without
+field table state, while field blocks refer to the state of the table without

```suggestion
field table state, while field sections refer to the state of the table without
```

>  
-Like HTTP/2, HTTP/3 does not use the Connection header field to indicate
-connection-specific header fields; in this protocol, connection-specific
-metadata is conveyed by other means.  An endpoint MUST NOT generate an HTTP/3
-message containing connection-specific header fields; any message containing
-connection-specific header fields MUST be treated as malformed ({{malformed}}).
+Like HTTP/2, HTTP/3 does not use the Connection field to indicate

Again, it's perfectly OK to call it a "header field" if it hasn't said it can be used in trailers.

>  
-Like HTTP/2, HTTP/3 does not use the Connection header field to indicate
-connection-specific header fields; in this protocol, connection-specific
-metadata is conveyed by other means.  An endpoint MUST NOT generate an HTTP/3
-message containing connection-specific header fields; any message containing
-connection-specific header fields MUST be treated as malformed ({{malformed}}).
+Like HTTP/2, HTTP/3 does not use the Connection field to indicate
+connection-specific fields; in this protocol, connection-specific metadata is
+conveyed by other means.  An endpoint MUST NOT generate an HTTP/3 message

```suggestion
conveyed by other means.  An endpoint MUST NOT generate an HTTP/3 field section
```

>  
-#### Pseudo-Header Fields
+#### Pseudo-Fields

There are not pseudo-trailer fields, and I fervently hope we won't be defining any. Let's just keep it as pseudo-header.

>  
-To allow for better compression efficiency, the cookie header field {{!RFC6265}}
-MAY be split into separate header fields, each with one or more cookie-pairs,
-before compression. If a decompressed header list contains multiple cookie
-header fields, these MUST be concatenated into a single octet string using the
-two-octet delimiter of 0x3B, 0x20 (the ASCII string "; ") before being passed
-into a context other than HTTP/2 or HTTP/3, such as an HTTP/1.1 connection, or a
+To allow for better compression efficiency, the "Cookie" field {{!RFC6265}} MAY
+be split into separate field lines, each with one or more cookie-pairs, before
+compression. If a decompressed field list contains multiple cookie field lines,

```suggestion
compression. If a decompressed field section contains multiple cookie field lines,
```

>  
 A request or response that includes a payload body can include a
-`content-length` header field.  A request or response is also malformed if the
-value of a content-length header field does not equal the sum of the DATA frame
-payload lengths that form the body.  A response that is defined to have no
-payload, as described in Section 3.3.2 of {{!RFC7230}} can have a non-zero
-content-length header field, even though no content is included in DATA frames.
+`content-length` field.  A request or response is also malformed if the value of

Again, C-L is very definitely a header field; it cannot appear in a trailer.

> @@ -809,7 +809,7 @@ using the same format described for responses in {{request-response}}.
 Due to reordering, push stream data can arrive before the corresponding
 PUSH_PROMISE frame.  When a client receives a new push stream with an
 as-yet-unknown Push ID, both the associated client request and the pushed
-request headers are unknown.  The client can buffer the stream data in
+request fields are unknown.  The client can buffer the stream data in

Can you push request trailers?

>  
 ~~~~~~~~~~  drawing
  0                   1                   2                   3
  0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 |                          Push ID (i)                        ...
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-|                       Header Block (*)                      ...
+|                        Field Block (*)                      ...

See previous comments about Block v Section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3513#pullrequestreview-373968241