Date: Mon, 18 Nov 2019 18:57:11 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK53WJDDYKGYAEHXWRN34CGIPEVBNHHB532IFY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3201/review/318758305@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3201@github.com>
References: <quicwg/base-drafts/pull/3201@github.com>
Subject: Re: [quicwg/base-drafts] enforce the active_connection_id_limit
 (#3201)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5dd35a07557f8_4cbd3fafe0acd9681009dc";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-od_ReT_T9aEDIvWAqnxNpdK5Ts>


----==_mimepart_5dd35a07557f8_4cbd3fafe0acd9681009dc
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -999,8 +999,10 @@ retired are considered active; any active connection ID can be used.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  Endpoints store received connection IDs for future use
 and advertise the number of connection IDs they are willing to store with the
-active_connection_id_limit transport parameter.  An endpoint SHOULD NOT provide
-more connection IDs than the peer's limit.
+active_connection_id_limit transport parameter.  An endpoint MUST NOT provide
+more connection IDs than the peer's limit.  An endpoint that receives more
+connection IDs than its advertised active_connection_id_limit MUST close the
+connection with an error of type CONNECTION_ID_LIMIT_ERROR.

@huitema That's not correct:
> Endpoints MUST NOT exceed the limit set by their peer. An endpoint that receives a frame with a stream ID exceeding the limit it has sent MUST treat this as a connection error of type STREAM_LIMIT_ERROR 

and 
>  An endpoint MUST terminate a connection with a FLOW_CONTROL_ERROR error if it receives more data than the maximum data value that it has sent

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3201#discussion_r347710819
----==_mimepart_5dd35a07557f8_4cbd3fafe0acd9681009dc
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3201#discussion_r347710819">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -999,8 +999,10 @@ retired are considered active; any active connection ID can be used.
 An endpoint SHOULD ensure that its peer has a sufficient number of available and
 unused connection IDs.  Endpoints store received connection IDs for future use
 and advertise the number of connection IDs they are willing to store with the
-active_connection_id_limit transport parameter.  An endpoint SHOULD NOT provide
-more connection IDs than the peer&#39;s limit.
+active_connection_id_limit transport parameter.  An endpoint MUST NOT provide
+more connection IDs than the peer&#39;s limit.  An endpoint that receives more
+connection IDs than its advertised active_connection_id_limit MUST close the
+connection with an error of type CONNECTION_ID_LIMIT_ERROR.
</pre>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=7464128" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/huitema">@huitema</a> That's not correct:</p>
<blockquote>
<p>Endpoints MUST NOT exceed the limit set by their peer. An endpoint that receives a frame with a stream ID exceeding the limit it has sent MUST treat this as a connection error of type STREAM_LIMIT_ERROR</p>
</blockquote>
<p>and</p>
<blockquote>
<p>An endpoint MUST terminate a connection with a FLOW_CONTROL_ERROR error if it receives more data than the maximum data value that it has sent</p>
</blockquote>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3201?email_source=notifications&amp;email_token=AFTOJKYF7RWCCJBVSIWU4Y3QUNIYPA5CNFSM4JKANHMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL753II#discussion_r347710819">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKYPW3YWIFFBOBP47PDQUNIYPANCNFSM4JKANHMA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK725BBHA642N2DUAIDQUNIYPA5CNFSM4JKANHMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL753II.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3201?email_source=notifications\u0026email_token=AFTOJKYF7RWCCJBVSIWU4Y3QUNIYPA5CNFSM4JKANHMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL753II#discussion_r347710819",
"url": "https://github.com/quicwg/base-drafts/pull/3201?email_source=notifications\u0026email_token=AFTOJKYF7RWCCJBVSIWU4Y3QUNIYPA5CNFSM4JKANHMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL753II#discussion_r347710819",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5dd35a07557f8_4cbd3fafe0acd9681009dc--