Re: [quicwg/base-drafts] More ECN verification failure modes (#2198)

Magnus Westerlund <notifications@github.com> Thu, 20 December 2018 11:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2916C130E35 for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 03:09:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WQGd2Sx7KK6w for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 03:09:31 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D59C130E1B for <quic-issues@ietf.org>; Thu, 20 Dec 2018 03:09:31 -0800 (PST)
Date: Thu, 20 Dec 2018 03:09:30 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545304170; bh=Gq96F4f6Kiy9E3RbbV/C0wro6flvmRWipf/ea4dJSZI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uiKyKokY1lAM2wapr99S8KrofyntQ+aPCBAU1IK+g1BYp0HdPYgi69YUn19xkELex 0Mvl9b3lIpUR3gN2x0127Qr7POvCGM4Rb4JjOSudLntmAhgI7u4iub7RY4a9+pKr9t bAbVRmPMfKWLeG6tWze4BbaKITjq1YmvN4NPnCQ4=
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe8a0c1e4a9c0957cb2a7411deea800e82d500e5192cf0000000118333a6a92a169ce17566533@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2198/448959986@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2198@github.com>
References: <quicwg/base-drafts/issues/2198@github.com>
Subject: Re: [quicwg/base-drafts] More ECN verification failure modes (#2198)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1b786a4175d_68ff3fba252d45b45305f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-qlvqjXW7aOh4LGAkES-jVGNcm8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 11:09:33 -0000

I think the best in this case is to not preform vierfication for out of order ACKs. 

The current sentence in Section 13.3.2 (-17):
"Counts MUST NOT be verified if the ACK frame does not increase the largest received packet number at the endpoint."

Which I interpret to mean that what PN the ACK reference (sender-receiver direction), rather than the PN of the receiver to sender direction. Can you @martinthomson fix that? That way #2205 can focus on the other aspect and ignore ECN as it would not care. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2198#issuecomment-448959986