Re: [quicwg/base-drafts] PMTUD (kitchen-sink version) (#106)

martinduke <notifications@github.com> Tue, 03 January 2017 18:13 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4822129A95 for <quic-issues@ietfa.amsl.com>; Tue, 3 Jan 2017 10:13:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.4
X-Spam-Level:
X-Spam-Status: No, score=-7.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RP_MATCHES_RCVD=-3.1, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8UPpnWIWMcPj for <quic-issues@ietfa.amsl.com>; Tue, 3 Jan 2017 10:13:41 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CDB1D129A73 for <quic-issues@ietf.org>; Tue, 3 Jan 2017 10:13:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ppRfPnOMsToIfNWSmsFHvgXYLq8=; b=kO+O8CEYfETVmj0B 4gprrTT/QpZfK96/zmt+nGYxqrWyUfaIvRVLRX8J1YmeST5yLLkpzH6zbersJeF3 3aDQJX9YA75RTw/7UGWlawydY6BXPc+zdsyUmYugDBzphD3ialOk+3JTKQgJqlaY PY79fFoAIzkunYpvhzW1dnEK+bQ=
Received: by filter0858p1mdw1.sendgrid.net with SMTP id filter0858p1mdw1-18677-586BE9C4-7C 2017-01-03 18:13:24.632921324 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id N7NqyQmeSPmHHDffMSTQZw for <quic-issues@ietf.org>; Tue, 03 Jan 2017 18:13:24.562 +0000 (UTC)
Date: Tue, 03 Jan 2017 10:13:24 -0800
From: martinduke <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/106/review/14980935@github.com>
In-Reply-To: <quicwg/base-drafts/pull/106@github.com>
References: <quicwg/base-drafts/pull/106@github.com>
Subject: Re: [quicwg/base-drafts] PMTUD (kitchen-sink version) (#106)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_586be9c474783_6bcc3f98a04bf140731f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3rkY+EAHpAbTX6KbkwPLnYjXD7nDeECm7vHB 3eshfZzSI44rNjfDe6sI/ktRhSKXev+VHmUCX0g1L/37lXYB1BElCRVImPGNSxdzSbkps0jsJ2nxCa giZ2moJWzNbeK0+7Gr9en8HNGD/KLTfwWtY2OIhvK9yUDt+wU9wxg57PhLjepLltR92DCfgf85a5Gg 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-rPRO4hbaIIf7VUM4v1CNQ1OIeo>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 18:13:43 -0000

martinduke commented on this pull request.



> +
+QUIC endpoints MAY set DF and pad packets when implementing probes as described in
+{{!RFC1191}}, {{!RFC1981}}, or {{!RFC4821}}.
+
+QUIC endpoints MAY set DF and pad packets when it has evidence that the path between two
+previously used IP addresses has changed.
+
+### Special Considerations for Path MTU Discovery 
+
+Traditional ICMP-based path MTU discovery ({{!RFC1191}}, {{!RFC1981}}) is
+potentially vulnerable to off-path attacks that succesfully guess the IP/port 4-tuple
+and reduce the MTU to a bandwidth-inefficient value. TCP connections mitigate this
+risk by using the (at minimum) 8 bytes of transport header echoed in the ICMP message
+to validate the TCP sequence number as valid for the current connection. However, as
+QUIC operates over UDP, this echoed information may consist only of the IP and UDP
+headers, which hold no connection-specific context except the IP/port 4-tuple.

That's a good point. How about "this echoed information may consist only of the IP and UDP headers, which usually has insufficient entropy to mitigate off-path attacks." ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/106