Re: [quicwg/base-drafts] Editorial fix for #2479 (#2877)

Martin Thomson <notifications@github.com> Tue, 09 July 2019 02:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CE6B1200E5 for <quic-issues@ietfa.amsl.com>; Mon, 8 Jul 2019 19:34:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gQzpJqzacIFf for <quic-issues@ietfa.amsl.com>; Mon, 8 Jul 2019 19:34:55 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B9271200DB for <quic-issues@ietf.org>; Mon, 8 Jul 2019 19:34:55 -0700 (PDT)
Date: Mon, 08 Jul 2019 19:34:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1562639693; bh=pe6goAXPlVc6Yol1DslJ6gSO9kyaBGWDXUaiZStgx4Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WMnKgIt8Whp9T1sISyog7s9Z9XiHu9HmdDqJUELPdMeP2vd3k4a1QLL92UzyI0wiv RNUgGJYPucmR0utPVePEWkalnAdN3eAOEUZSM8YIg4ToUSjyCkRvxCf/PrK9iyUBL8 PB76Er3Xd/jevDRzT+oChnVEcG0Z7KNAOrJHe5rM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYKMTJRMTVSMYLRDDN3GEX43EVBNHHBXP3RNI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2877/review/259243190@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2877@github.com>
References: <quicwg/base-drafts/pull/2877@github.com>
Subject: Re: [quicwg/base-drafts] Editorial fix for #2479 (#2877)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d23fd4dd07c3_2c0c3fd988acd9649468b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-tuk11EwTrfrDA0BNW23WHk5l3Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2019 02:34:57 -0000

martinthomson commented on this pull request.



> -
-The connection ID lengths are followed by two connection IDs.  The connection
-ID associated with the recipient of the packet (the Destination Connection ID)
-is followed by the connection ID associated with the sender of the packet (the
-Source Connection ID).
+The byte contains the length in bytes of the Destination Connection ID (see
+{{connection-id}}) field that follows it.  This length is encoded as an 8-bit
+unsigned integer.  The Destination Connection ID field follows the DCID Len
+field and is between 0 and 255 bytes in length.
+
+The byte following the Source Connection ID contains the length in bytes
+of the Source Connection ID field that follows it.  This length is encoded as
+a 8-bit unsigned integer.  The Source Connection ID field follows the SCID Len
+field and is between 0 and 255 bytes in length.
+
+{{negotiating-connection-ids}} describes the use of the source and destination

This is what is causing CI to fail.  This anchor is in a different document.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2877#pullrequestreview-259243190