Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)
janaiyengar <notifications@github.com> Wed, 02 August 2017 00:15 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8F5D128BC8 for <quic-issues@ietfa.amsl.com>; Tue, 1 Aug 2017 17:15:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.298
X-Spam-Level:
X-Spam-Status: No, score=-9.298 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZcUbGSRbutcU for <quic-issues@ietfa.amsl.com>; Tue, 1 Aug 2017 17:14:59 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext5.iad.github.net [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C9FA1275FD for <quic-issues@ietf.org>; Tue, 1 Aug 2017 17:14:59 -0700 (PDT)
Date: Tue, 01 Aug 2017 17:14:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1501632898; bh=lsk/qf5jaBX99P+VfB2sepb7qGIhzLkjOUxYhJYv3oA=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fZiswMTzQdab5GZSVcRLUuRJ+/CcLIKQPa2Ovb6K7NSJ24y/1m35FohfWXwnhZRqz OWOddk22WQoC+26mBW48LXjXyNefUnHaiCq/gcrxKTssNMeuT+tsWalEtZAn2FMo43 oHdC8B4jfXAAi9q0d082anUBFH382bseQ7Xfsfrw=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8506141744d00bde9824482c65ae84b39d31d4b592cf000000011598db8292a169ce0d7b2095@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/498/review/53671279@github.com>
In-Reply-To: <quicwg/base-drafts/pull/498@github.com>
References: <quicwg/base-drafts/pull/498@github.com>
Subject: Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59811982e77b6_6a0c3fda616d3c301030b8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-uuTnVPfJqDw-8CX3PagEopO-NA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 00:15:01 -0000
janaiyengar commented on this pull request. > @@ -1232,6 +1232,15 @@ client MUST terminate with a VERSION_NEGOTIATION_ERROR error code if version negotiation occurred but it would have selected a different version based on the value of the supported_versions list. +When an endpoint accepts multiple QUIC versions, it can potentially interpret +transport parameters as they are defined by any of the QUIC versions it +supports. Since the QUIC protocol relies on transport parameters for +authenticating the version, the position and the format of the version fields in +transport parameters MUST be consistent across all QUIC versions supported by +the client. If a version of QUIC needs to define a new format for transport +parameters, it MUST define and use a new TLS extension for transport parameters This isn't defined as a TLS extension in this document, but the format is specified as the layout for in the TransportParameters field in the quic_transport_parameters TLS extension (se line 1076 above.) I think this text probably belongs there, along with the description of the wire layout, instead of here with version negotiation. I think the text is fine, but I would move it up there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/498#discussion_r130760246
- [quicwg/base-drafts] Version validation fields ca… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… MikkelFJ
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… Victor Vasiliev
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… Mike Bishop
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… janaiyengar
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson
- Re: [quicwg/base-drafts] Version validation field… ianswett
- Re: [quicwg/base-drafts] Version validation field… janaiyengar
- Re: [quicwg/base-drafts] Version validation field… Martin Thomson