Date: Wed, 12 Dec 2018 06:59:16 -0800
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab55daf8213997913b351a7ccc24c7ebe0ff6037d492cf000000011828e44492a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113/review/184220206@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2113@github.com>
References: <quicwg/base-drafts/pull/2113@github.com>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation
 (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c11224496407_2d603fcfeb2d45c4109185";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-xB6EmxXYebRJhXaXqFdXOPoVl8>


----==_mimepart_5c11224496407_2d603fcfeb2d45c4109185
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

larseggert commented on this pull request.



>  
 * The total increase in ECT(0), ECT(1), and CE counters reported in the ACK
   frame MUST be at least the total number of QUIC packets newly acknowledged in
-  this ACK frame.
+  this ACK frame. This detects if the network changes ECT(0), ECT(1) or CE to
+  Not-ECT.
+
+If the sender does not have state to determine if a particular packet number is
+newly acknowledged or not, then the comparison SHOULD NOT be performed. By the

Is this really a SHOULD NOT? If the sender doesn't have that state, it **CANNOT** perform that check. That's not a 2119 keyword, unfortunately :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184220206
----==_mimepart_5c11224496407_2d603fcfeb2d45c4109185
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@larseggert</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2113#discussion_r241047613">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  
 * The total increase in ECT(0), ECT(1), and CE counters reported in the ACK
   frame MUST be at least the total number of QUIC packets newly acknowledged in
-  this ACK frame.
+  this ACK frame. This detects if the network changes ECT(0), ECT(1) or CE to
+  Not-ECT.
+
+If the sender does not have state to determine if a particular packet number is
+newly acknowledged or not, then the comparison SHOULD NOT be performed. By the
</pre>
<p>Is this really a SHOULD NOT? If the sender doesn't have that state, it <strong>CANNOT</strong> perform that check. That's not a 2119 keyword, unfortunately :-)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184220206">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq98M1TZiPgysogmQ_JObz26oB3qfks5u4RnEgaJpZM4ZNkhQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1hKxPaEU1swaX6ZZaHsRFJNsf6Rks5u4RnEgaJpZM4ZNkhQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@larseggert commented on #2113"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184220206"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184220206",
"url": "https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184220206",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c11224496407_2d603fcfeb2d45c4109185--