IETF Logo Mail Archive

Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)

ianswett <notifications@github.com> Wed, 24 October 2018 02:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E3FB130DCA for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 19:10:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gA-sc-N0zGCB for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 19:10:40 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF1DE128CE4 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 19:10:40 -0700 (PDT)
Date: Tue, 23 Oct 2018 19:10:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540347039; bh=5Ua2rpQvuhz+lc3/wOV21CEFCnjKn62x35vmHsBkeP0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hkcg1/THn4iBLH95YW21xyR6DR3AWU1fZLLSNk4ESU2tTW46waUUlMXYm37wbGCsW 9k3CH4Eu1D2lhhjjZH0dFjklFb50TvH5UJA3zWd3k7qE0F1tqo1XtPlaqnXk5J4ReN tOKKuCwf6z4T28MxboiPwxpsYj2t0NhSBOD3qcvk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab246eb0d11f0b5c0f42bb24d7d7a2ed83774c018292cf0000000117e7969f92a169ce162e64dc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1895/review/167706157@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1895@github.com>
References: <quicwg/base-drafts/pull/1895@github.com>
Subject: Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfd49f89220_e9a3fa82aad45b43027dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-xq_UYhBQdfEOAxZ3K2riEZCPZ0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 02:10:43 -0000

ianswett commented on this pull request.



>  verified through an address validation token (delivered via a Retry packet or
-a NEW_TOKEN frame) or by processing any message from the client encrypted using
-the Handshake keys.  This limit exists to mitigate amplification attacks.
+a NEW_TOKEN frame), by processing any message from the client encrypted using
+the Handshake keys, or by processing a TLS ClientHello with a valid
+pre-shared key.  This limit exists to mitigate amplification attacks.

Given this is in the validation section, why not remove this entire sentence?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1895#discussion_r227622516

v2.29.0 | Report a Bug | By Email | System Status