Re: [quicwg/base-drafts] A pacing algorithm (#3630)

Martin Thomson <notifications@github.com> Thu, 14 May 2020 07:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61EC33A0366 for <quic-issues@ietfa.amsl.com>; Thu, 14 May 2020 00:23:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.727
X-Spam-Level:
X-Spam-Status: No, score=-1.727 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UBJPsqHPJzLr for <quic-issues@ietfa.amsl.com>; Thu, 14 May 2020 00:23:41 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BD1A3A02C1 for <quic-issues@ietf.org>; Thu, 14 May 2020 00:23:41 -0700 (PDT)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id B842B282B9C for <quic-issues@ietf.org>; Thu, 14 May 2020 00:23:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589441020; bh=PUMA6+WWSb1MdscrHnSFCxN7iTv4k5NSsq7l6X6DutI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=z/CiVysayagCdNwlfoVWSMrP4P83kAwaY8Q7ZJWkKUgmZjiz7BwwgpCGUFHLs7ceD L7kw5GwRXoFqRyoOBsYEjZhZz5TtSnmK8IiYZDMgSZFbTIcQ1OW/O5GW1wVJvx+qF2 mzObVvgUhyU71dbmGwp/yVD/khw6z01pTEhGizv8=
Date: Thu, 14 May 2020 00:23:40 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6BPRM72TW6HQU4R3F4ZDJPZEVBNHHCJCUB5E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3630/review/411528984@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3630@github.com>
References: <quicwg/base-drafts/pull/3630@github.com>
Subject: Re: [quicwg/base-drafts] A pacing algorithm (#3630)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebcf1fca7fc0_65de3fb070ccd96c1568c9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-zOZgiOpqK4Lg-mrdt4A-pP_gJY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2020 07:23:44 -0000

@martinthomson commented on this pull request.



> @@ -897,9 +897,28 @@ congestion window, which is recommended to be the minimum of
 max_datagram_size is the current maximum size of a datagram for the connection,
 not including UDP or IP overhead.
 
-As an example of a well-known and publicly available implementation of a flow
-pacer, implementers are referred to the Fair Queue packet scheduler (fq qdisc)
-in Linux (3.11 onwards).
+Endpoints can implement pacing as they choose. A perfectly paced sender spreads

Will do.  I also noticed that that paragraph refined the initial congestion window, so I replaced the (re)definition with a section reference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3630#discussion_r424922708