Re: [quicwg/base-drafts] http-core and Friends (#3513)

Lucas Pardue <notifications@github.com> Thu, 12 March 2020 02:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2ABE3A0101 for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 19:12:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5K8s7vTtzIOY for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 19:12:55 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02AC23A0031 for <quic-issues@ietf.org>; Wed, 11 Mar 2020 19:12:42 -0700 (PDT)
Date: Wed, 11 Mar 2020 19:12:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583979161; bh=TBnV/sE2N6c/2PAJ/MwnhRfUzgsh72ijsagJyBkcguY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XO7gogiMfQCyH4vUl2ebWe2eeQU7sMxrXXsoThJerT9p/4B3ne1FpPJr+//Ym63By FyRHLF0Hdd9pvWWavijX5wscSp7PJFlp2SEa5d0/niIV1cssVQYumQH0QKOQ6TkrYs H9BLbxC+vgoKJVA4NN0Q3TCm6OefIJ/Us2Fb18/I=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK366RYYMLPSC7X7JUF4OV5ZTEVBNHHCFCTWBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3513/review/373234297@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3513@github.com>
References: <quicwg/base-drafts/pull/3513@github.com>
Subject: Re: [quicwg/base-drafts] http-core and Friends (#3513)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e699a9989a79_2c973f8e79ccd96c106617"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/02rzQ1nkw6mMPiCkSSpdQosIXMw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 02:12:57 -0000

LPardue commented on this pull request.



>  
-#### Pseudo-Header Fields
+#### Pseudo-Fields

Do we need to make this change? The requirement is that they MUST NOT appear in trailers

>  
-To allow for better compression efficiency, the cookie header field {{!RFC6265}}
-MAY be split into separate header fields, each with one or more cookie-pairs,
-before compression. If a decompressed header list contains multiple cookie
+To allow for better compression efficiency, the "Cookie" field {{!RFC6265}}
+MAY be split into separate field lines, each with one or more cookie-pairs,
+before compression. If a decompressed field list contains multiple cookie
 header fields, these MUST be concatenated into a single octet string using the

```suggestion
fields, these MUST be concatenated into a single octet string using the
```

> @@ -1193,8 +1194,8 @@ connection error ({{errors}}) of type H3_FRAME_UNEXPECTED.
 
 ### HEADERS {#frame-headers}
 
-The HEADERS frame (type=0x1) is used to carry a header block, compressed using
-QPACK. See [QPACK] for more details.
+The HEADERS frame (type=0x1) is used to carry a block of HTTP fields, compressed
+using QPACK. See [QPACK] for more details.
 
 ~~~~~~~~~~  drawing
  0                   1                   2                   3

the diagram still contains "Header Block"

> @@ -1387,7 +1388,7 @@ error of type H3_SETTINGS_ERROR.
 ### PUSH_PROMISE {#frame-push-promise}
 
 The PUSH_PROMISE frame (type=0x5) is used to carry a promised request header
-set from server to client on a request stream, as in HTTP/2.
+field set from server to client on a request stream, as in HTTP/2.
 
 ~~~~~~~~~~  drawing
  0                   1                   2                   3

the diagram still contains "Header Block"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3513#pullrequestreview-373234297