IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

mirjak <notifications@github.com> Tue, 11 December 2018 15:43 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B769130DEA for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 07:43:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eb1OIBX_dGj0 for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 07:43:27 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 755B8130DE9 for <quic-issues@ietf.org>; Tue, 11 Dec 2018 07:43:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=w8B/mLiI7cIcBdcEUFPB5jlj3Xg=; b=ZZ7Kz8auKRz8xBn7 GfCxu0s0vO3ZnTthV/hoqXuD/XeL/XGhlwDtKzXliOYFOpMMuVavt/i6Y+RnMouG BXL7UxFQWSQPLZL+olLmizpff+ozTxa0vsjrPhEEeuLcRiiumauoFT1aZmTW7Brb xoA37x1evmCWQDh6Si58w1ld6vo=
Received: by filter1387p1mdw1.sendgrid.net with SMTP id filter1387p1mdw1-18309-5C0FDB1E-C 2018-12-11 15:43:26.297453257 +0000 UTC m=+61877.027150876
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0016p1iad2.sendgrid.net (SG) with ESMTP id hGmW29IOSNm4OwIqU6RHNQ for <quic-issues@ietf.org>; Tue, 11 Dec 2018 15:43:26.309 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id 38320C003A for <quic-issues@ietf.org>; Tue, 11 Dec 2018 07:43:26 -0800 (PST)
Date: Tue, 11 Dec 2018 15:43:26 +0000
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab401cafc3069ee4e0ae8958eb74d6229561da124992cf0000000118279d1e92a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113/c446248746@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2113@github.com>
References: <quicwg/base-drafts/pull/2113@github.com>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c0fdb1e36512_621f3fc05acd45c4975c5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0O+zz8YrHmv884Og705Bu+luZiXvEldAsPTb FzEpoiR0zaa00w/4s5WR7+kny+++NKNKg0qdFAJ9bs6UeHX/7H9V3JT2FjHr7+PjKgerWS/5zxFNom 063Je/cylI0hxgYC5nOv1Rpx/hLEIqW4ribSHzgFHeDolrY13OGF2D3Png==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0CNHeO5XEwrGQ5MIR1e_c3l1BzQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2018 15:43:30 -0000

I think it could actually be good to at one short sentence to each bulletpoint to explain what the test is checking for; e.g. as you said on slack "This is to ensure that packets sent as ECT(0) are not arriving as ECT(1)."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#issuecomment-446248746

v2.31.3 | Report a Bug | By Email | System Status