IETF Logo Mail Archive

Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)

Jana Iyengar <notifications@github.com> Fri, 17 July 2020 01:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCFBE3A0E90 for <quic-issues@ietfa.amsl.com>; Thu, 16 Jul 2020 18:11:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x3CYBqAkGvxz for <quic-issues@ietfa.amsl.com>; Thu, 16 Jul 2020 18:11:26 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B48303A0E8F for <quic-issues@ietf.org>; Thu, 16 Jul 2020 18:11:26 -0700 (PDT)
Received: from github-lowworker-0f78100.ash1-iad.github.net (github-lowworker-0f78100.ash1-iad.github.net [10.56.25.48]) by smtp.github.com (Postfix) with ESMTP id 1D7AF2601F2 for <quic-issues@ietf.org>; Thu, 16 Jul 2020 18:11:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594948286; bh=SupCeYh3iFyiXUA4z5dJ2BgsexhiOaXO+/y5y9ZmW98=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CXkYHDoqqwT3B08Tq+8Se63oq12XKXBW1z5QFHXHwp0nthNOJ7bhcNV2chc0dmco/ Y0eAiJ2xbnhlKZsf3FGmrvZlsB+nWx9T8ikU+tyfc3GEHRcd1EmLzSv3WK5c2OO0gP D3Hj2CKpGriQ0TCC9Gf6XRzslihx0I31w+a1w+6c=
Date: Thu, 16 Jul 2020 18:11:25 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYLJ3TTYBO7XECNGMV5DTN33EVBNHHCOPRYC4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3917/c659768179@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3917@github.com>
References: <quicwg/base-drafts/pull/3917@github.com>
Subject: Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f10fabdcca75_27fc3fb7416cd96839515e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0I-b9BDL_wF3eNj-lOZbFmBTnIM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2020 01:11:28 -0000

I agree with @ianswett : I don't think this is necessary... perhaps a comment might help clarify that implementers should be careful about integer division here?

FWIW, you'll also need to multiply bytes_acked in OnCongestionEvent() by 0.5, and reset it to 0 on a persistent congestion event.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3917#issuecomment-659768179

v2.30.2 | Report a Bug | By Email | System Status