Re: [quicwg/base-drafts] Push ID limit checking in DUPLICATE_PUSH (#2695)
Martin Thomson <notifications@github.com> Tue, 14 May 2019 01:45 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE7F81200B8 for <quic-issues@ietfa.amsl.com>; Mon, 13 May 2019 18:45:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.606
X-Spam-Level:
X-Spam-Status: No, score=-6.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iUWB0OGA1wNS for <quic-issues@ietfa.amsl.com>; Mon, 13 May 2019 18:44:59 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1CB2E120026 for <quic-issues@ietf.org>; Mon, 13 May 2019 18:44:59 -0700 (PDT)
Date: Mon, 13 May 2019 18:44:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557798298; bh=kvaOEFPPdTWLa4Mnnv5HrFsj3y/2gFoTsRkgNLJ2XFI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NMmaTt8Je8l4C5Fttpj7+4n7S5vzjgLtrxSz0KguPQR+ts4W+FlW6rtfOxOibLpTF zs8mbAAjXXvWy7xRvo9Cpcno824hReS7giP2zjoIJk09A0Zf4VIRXOkh2cNBDntIEU dcF+6+REVmaQckfmTurWcGKDZOXz09Yv0QyaIHb8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4PN2ETKWOBRZVDMVN245IBVEVBNHHBU36B5A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2695/review/236992784@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2695@github.com>
References: <quicwg/base-drafts/pull/2695@github.com>
Subject: Re: [quicwg/base-drafts] Push ID limit checking in DUPLICATE_PUSH (#2695)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cda1d9aa98a_5b053fa800acd964198813"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0KKUk071AasJBq2COKf-5IaN9h8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2019 01:45:01 -0000
martinthomson commented on this pull request.
I think that we have a frame name problem, otherwise, this is fine.
> @@ -890,7 +890,11 @@ of a DUPLICATE_PUSH frame as a connection error of type HTTP_UNEXPECTED_FRAME.
The DUPLICATE_PUSH frame carries a single variable-length integer that
identifies the Push ID of a resource that the server has previously promised
-(see {{frame-push-promise}}).
+(see {{frame-push-promise}}), though that promise might not be received before
+this frame. A server MUST NOT use a Push ID that is larger than the client has
+provided in a MAX_PUSH_ID frame ({{frame-max-push-id}}). A client MUST treat
+receipt of a PUSH_PROMISE that contains a larger Push ID than the client has
or DUPLICATE_PUSH?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2695#pullrequestreview-236992784
- [quicwg/base-drafts] Push ID limit checking in DU… Mike Bishop
- Re: [quicwg/base-drafts] Push ID limit checking i… ianswett
- Re: [quicwg/base-drafts] Push ID limit checking i… Martin Thomson
- Re: [quicwg/base-drafts] Push ID limit checking i… Mike Bishop
- Re: [quicwg/base-drafts] Push ID limit checking i… Lucas Pardue
- Re: [quicwg/base-drafts] Push ID limit checking i… Mike Bishop
- Re: [quicwg/base-drafts] Push ID limit checking i… Mike Bishop