Re: [quicwg/base-drafts] describe what happens when the PTO timer expires (#2455)

Martin Thomson <notifications@github.com> Tue, 12 February 2019 02:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 980CF129619 for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 18:26:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OMS4qVGxmiHL for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 18:26:27 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B174C1276D0 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 18:26:27 -0800 (PST)
Date: Mon, 11 Feb 2019 18:26:26 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549938386; bh=L6dZRYLThephCkZRGMPcXTESe/d/EtTCO/VxKDcIWDQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hebXaVanEfijoenV7r0Ai73wIcYw+94jvmjpHwetuq+T1UbvlE27uTpF6bMeraAc3 q1OAZCkMJ6/fOwRJ7z+upFPBNoIk+cR1rV0QUsaZ6rIBu7Kr5oUOyCK/CSoUNV8IGW 1+34on1jAEMukwHPM0DNWuLGsVyWTlRYJQ60xx5s=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab957ef7a58369d35fd6d4f7471168de7080023e6b92cf000000011879f0d292a169ce1861d625@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2455/review/202455535@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2455@github.com>
References: <quicwg/base-drafts/pull/2455@github.com>
Subject: Re: [quicwg/base-drafts] describe what happens when the PTO timer expires (#2455)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c622ed241ed4_3f283ffd1dcd45c46335e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0LD1MCakgK05qtpIsJAIkawhU4k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2019 02:26:30 -0000

martinthomson commented on this pull request.



> @@ -506,9 +506,10 @@ delay sending an acknowledgement.
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
 immediately.
 
-When a PTO timer expires, the PTO period MUST be set to twice its current value.
-This exponential reduction in the sender's rate is important because the PTOs
-might be caused by loss of packets or acknowledgements due to severe congestion.
+When a PTO timer expires, the sender sends a probe packet as described in the
+next section. The PTO period MUST be set to twice its current value. This

```suggestion
next section. The PTO period then MUST be set to twice its current value. This
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2455#pullrequestreview-202455535