[quicwg/base-drafts] Prioritize Handshake probe packet over Short packet (#3583)

Tatsuhiro Tsujikawa <notifications@github.com> Wed, 15 April 2020 06:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2771B3A0FEA for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 23:55:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.721
X-Spam-Level:
X-Spam-Status: No, score=-1.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fvVjH8f0pF2J for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 23:55:18 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 616373A0FE9 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 23:55:18 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id 2BE63E00A6 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 23:55:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586933717; bh=KXWgDJm8cRb9rKvmSBA7j/NirQ/8ziBKE3VRbrqivhs=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=M8igjXP+Q7SrMDthMqklllVptMpmOCNPcmPYetEl9LcA0qLb3EJRNjGmu6Pb77S7i oJ4iUw3G/AzC4CONaQxuQMHY4r6dsS1uFJrxedgx2soqZ/2twLxzoPgXOQLbeCnyY7 WcCe45WwLWanCxjhT/mdZQHgRhn2HeBLTeTDB2hU=
Date: Tue, 14 Apr 2020 23:55:17 -0700
From: Tatsuhiro Tsujikawa <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4X6SV6OLEE6TFEY354UKINLEVBNHHCHRCEXQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3583@github.com>
Subject: [quicwg/base-drafts] Prioritize Handshake probe packet over Short packet (#3583)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e96afd51db37_d953f84dbccd9646691b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tatsuhiro-t
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0NrCJR9cSm1B5FZt1y3tXoQCWOI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 06:55:20 -0000

The packet number space that endpoint should send probe packet is
determined by GetEarliestTimeAndSpace function.  It chooses
packet number space where the latest packet has earliest dispatch
time.

Suppose client sent 2 packets: Handshake(client_handshake#0) and
Short packet(client_short#0).

Somehow it didn't get any ACK for them, on first PTO timeout, it
resent Handshake (client_handshake#1).  This makes Short packet
number space becomes the earliest packet number space and next
PTO timeout, client sent Short probe packet assuming that
IsHandshakeCompleted() means handshake completion not handshake
confirmation.  I think it should instead send Handshake probe
packet in this case.  We have unified PTO timer and sending probe
in alternate manner is a bit strange.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3583