IETF Logo Mail Archive

Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

ianswett <notifications@github.com> Thu, 07 February 2019 15:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F26B2129284 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 07:51:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.1
X-Spam-Level:
X-Spam-Status: No, score=-6.1 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eIklotPBPeNR for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 07:51:30 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D837412008F for <quic-issues@ietf.org>; Thu, 7 Feb 2019 07:51:29 -0800 (PST)
Date: Thu, 07 Feb 2019 07:51:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549554689; bh=GjJgQcJjKTIKs4tiwdUg/vx8Zw6wCAhr4QTIHU0Pm6A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bLEwIGAfPvv1fMM211VNPgPAGjI27MxsIzxWJUTlovCga7A8a32zkCh23djZjp8IP uqSb9Yf/SNB3RSWNdlGl6iIUAnGqa7ciJWwHZIE/QV19qOH6A+dZGsJVfLd/QGgr4Q Suttg4FEjMgNeiLDG4EpSLfFFYay656iGUmMkU8U=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab233a1b5c0581f71a32721901fa8ff44c32249f7292cf000000011874160192a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417/c461480665@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2417@github.com>
References: <quicwg/base-drafts/pull/2417@github.com>
Subject: Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c540110a6f_3be3faf662d45c4303e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0Qa-VczVKLk8qYNeDxG_EaWiy8o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 15:51:32 -0000

Good point, maybe we should pick a different language then.

On Thu, Feb 7, 2019 at 10:24 AM Marten Seemann <notifications@github.com>
wrote:

> *@marten-seemann* commented on this pull request.
> ------------------------------
>
> In draft-ietf-quic-recovery.md
> <https://github.com/quicwg/base-drafts/pull/2417#discussion_r254728752>:
>
> > @@ -819,6 +819,16 @@ kGranularity:
>  kInitialRtt:
>  : The RTT used before an RTT sample is taken. The RECOMMENDED value is 100ms.
>
> +kPacketNumberSpace:
> +: An enum to enumerate the three packet number spaces.
> +~~~
> +  enum kPacketNumberSpace {
> +    Initial,
> +    Handshake,
> +    Application data,
>
> I renamed the variable.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/pull/2417#discussion_r254728752>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ATJJcYQWGpEZU-wVBlGcVYQ9EhhelE9xks5vLEVJgaJpZM4aidmj>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#issuecomment-461480665

v2.23.0 | Report a Bug | By Email