IETF Logo Mail Archive

Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)

Martin Thomson <notifications@github.com> Tue, 14 April 2020 23:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E9563A1280 for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 16:29:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.649
X-Spam-Level:
X-Spam-Status: No, score=-1.649 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YzBNUWhCfV_s for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 16:29:56 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E86613A127F for <quic-issues@ietf.org>; Tue, 14 Apr 2020 16:29:55 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12]) by smtp.github.com (Postfix) with ESMTP id DE00EC6056C for <quic-issues@ietf.org>; Tue, 14 Apr 2020 16:29:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586906994; bh=CWO6aksLj+C5zXNDAFraBUPUosCkWUl3ig7tWdlkQA8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TR0MMWtRmGVfoV7qF3ZpK0Dndl5bcMWo6fTn1iGmVoQApm6AUfVGHNmXPPrp+oh2N GMp0qxmSynDI8rgKrJiJZEIGg0zdAtN7Q0mgOYKhtRyrmPWsj8YQRhSmQJEbWf+ne/ UWsA6V14OZIkLrwGr/hQltbZKC0qIujLdixJDDbA=
Date: Tue, 14 Apr 2020 16:29:54 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY7EXNHVJK2GQIFWPF4UIUHFEVBNHHCHD4D3E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3572/review/393362608@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3572@github.com>
References: <quicwg/base-drafts/pull/3572@github.com>
Subject: Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e964772cd402_63443fc65d4cd96c14777a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0SQ4a5c8B7cY5XvdTMJoLcflzo0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2020 23:29:57 -0000

@martinthomson approved this pull request.



> +detect spurious losses.  Increasing reordering thresholds after losses
+are spuriously detected have proven useful in TCP, such as TCP-NCR
+{{?RFC4653}}, and are expected to be equally useful in QUIC.

The "such as" is injected at an odd point here, which seems to break up the flow.

```suggestion
detect spurious losses.  Increasing reordering thresholds after losses, as
recommended in TCP-NCR {{?RFC4653}}, have proven to be useful in TCP and are
expected to be equally useful in QUIC.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3572#pullrequestreview-393362608

v2.23.0 | Report a Bug | By Email