Re: [quicwg/base-drafts] Think carefully before blowing up (#3344)

Martin Thomson <notifications@github.com> Wed, 15 January 2020 23:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0B82120639 for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 15:33:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Vav3h-7CYi6 for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 15:33:55 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA93C12008F for <quic-issues@ietf.org>; Wed, 15 Jan 2020 15:33:55 -0800 (PST)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id 0DCD8520C2F for <quic-issues@ietf.org>; Wed, 15 Jan 2020 15:33:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579131235; bh=14LW/swgM2fEW25YhLjR4RySra+u3a9UwpiBss2QZm8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FxGbsYgs8GqhMDccQr1ShJBITnj1A+idnlb3s/MCDrerek+7/dSBazsl57Wk9bBY+ KENNuygqvclSVauI93NB4ELQOIRCCelxXSrhVg0ni8ybp4pA/hJS93U62iKaYPWPji jj5M7u7D/6Aq0LeU5SgFasYph7vBq68qTlExYvDU=
Date: Wed, 15 Jan 2020 15:33:54 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2LHGGZ2UTTAY72T7F4FTJ6FEVBNHHCBRUN3U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3344/review/343592427@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3344@github.com>
References: <quicwg/base-drafts/pull/3344@github.com>
Subject: Re: [quicwg/base-drafts] Think carefully before blowing up (#3344)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1fa162f27ec_24c3ffb7cacd96c995b2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0ZIqREb_J9Qy-NhK9E4akMbNXjU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 23:33:58 -0000

martinthomson commented on this pull request.



> +An endpoint MAY choose to treat a stream error as a connection error under
+certain circumstances.  Implementations need to consider the impact on
+outstanding requests before making this choice.

That case smells like a server bug.  You should not treat receipt of a legal frame as an error.  I assume that the RESET_STREAM was sent only in the case that the stream was fully acknowledged.  Otherwise that might have been a genuine problem, though still not cause for termination.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3344#discussion_r367162515