Re: [quicwg/base-drafts] Allow RST_STREAM to be sent and received after FIN (#781)
ekr <notifications@github.com> Tue, 19 September 2017 19:54 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F46E1321D8 for <quic-issues@ietfa.amsl.com>; Tue, 19 Sep 2017 12:54:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.299
X-Spam-Level:
X-Spam-Status: No, score=-9.299 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fnrV8o-1moRR for <quic-issues@ietfa.amsl.com>; Tue, 19 Sep 2017 12:53:59 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext5.iad.github.net [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D4C31320B5 for <quic-issues@ietf.org>; Tue, 19 Sep 2017 12:53:59 -0700 (PDT)
Date: Tue, 19 Sep 2017 12:53:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1505850838; bh=xDS/yDJwE8cGb2kziWWbzG79rp9yEG65ll7gRXxVGBw=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NUcpxAhzDjIdfy+glijqImK6wWsOMtofjf83WlfL6C0uezB932TYIqa7RT4YBG9Tx WN8HL3PhvZF8Oh5+BLJvS0d/U/TbEO8OKp7FvMJP+7Ju6KlQYj6Fr01YDynWfEcYmf OWnGm4xuLlsxsb1pu8wJwmK+kgxismfOeYsohTcs=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd81d18a911724b81493034231813f293833ed8da92cf0000000115d937d592a169ce0f6f21e9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/781/review/63782336@github.com>
In-Reply-To: <quicwg/base-drafts/pull/781@github.com>
References: <quicwg/base-drafts/pull/781@github.com>
Subject: Re: [quicwg/base-drafts] Allow RST_STREAM to be sent and received after FIN (#781)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59c175d6136f4_663c3fa5c07daf781033a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0_GKMZ9EMMbbqu1fZOQMAZdeZPo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 19:54:01 -0000
ekr commented on this pull request. > @@ -2615,8 +2615,10 @@ Any frame type that mentions a stream ID can be sent in this state. A stream that is in the "half-closed (local)" state MUST NOT be used for sending on new STREAM frames. Retransmission of data that has already been sent on -STREAM frames is permitted. An endpoint MAY also send MAX_STREAM_DATA and -STOP_SENDING in this state. +STREAM frames is permitted. If the stream is canceled or reset while in this +state, a RST_STREAM frame MAY be sent. A RST_STREAM frame sent in this state Are cancelled or reset different? > @@ -2648,6 +2650,10 @@ closes a stream SHOULD be discarded. An endpoint MAY choose to limit the period over which it ignores frames and treat frames that arrive after this time as being in error. +An endpoint may receive a RST_STREAM after a FIN if the peer resets the stream +after sending a FIN on it. In this case, the endpoint MAY discard any data that +it already received on that stream. I would think should > @@ -2615,8 +2615,10 @@ Any frame type that mentions a stream ID can be sent in this state. A stream that is in the "half-closed (local)" state MUST NOT be used for sending on new STREAM frames. Retransmission of data that has already been sent on -STREAM frames is permitted. An endpoint MAY also send MAX_STREAM_DATA and -STOP_SENDING in this state. +STREAM frames is permitted. If the stream is canceled or reset while in this +state, a RST_STREAM frame MAY be sent. A RST_STREAM frame sent in this state It's probably useful to say why you would do this. > @@ -2648,6 +2650,10 @@ closes a stream SHOULD be discarded. An endpoint MAY choose to limit the period over which it ignores frames and treat frames that arrive after this time as being in error. +An endpoint may receive a RST_STREAM after a FIN if the peer resets the stream +after sending a FIN on it. In this case, the endpoint MAY discard any data that I would put the "if first" so it reads "If the peer resets the stream...." > @@ -2615,8 +2615,10 @@ Any frame type that mentions a stream ID can be sent in this state. A stream that is in the "half-closed (local)" state MUST NOT be used for sending on new STREAM frames. Retransmission of data that has already been sent on -STREAM frames is permitted. An endpoint MAY also send MAX_STREAM_DATA and -STOP_SENDING in this state. +STREAM frames is permitted. If the stream is canceled or reset while in this +state, a RST_STREAM frame MAY be sent. A RST_STREAM frame sent in this state So I can also send multiple RST_STREAMs? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/781#pullrequestreview-63782336
- [quicwg/base-drafts] Allow RST_STREAM to be sent … janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… ianswett
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… ekr
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Mike Bishop
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Mike Bishop
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Mike Bishop
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Martin Thomson
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… janaiyengar
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Martin Thomson
- Re: [quicwg/base-drafts] Allow RST_STREAM to be s… Martin Thomson