Re: [quicwg/base-drafts] VarInt decoding pseudocode (#4316)

Mike Bishop <notifications@github.com> Fri, 30 October 2020 15:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 558CF3A0844 for <quic-issues@ietfa.amsl.com>; Fri, 30 Oct 2020 08:13:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pakr41pYSH1x for <quic-issues@ietfa.amsl.com>; Fri, 30 Oct 2020 08:13:10 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF60E3A00E0 for <quic-issues@ietf.org>; Fri, 30 Oct 2020 08:13:10 -0700 (PDT)
Received: from github.com (hubbernetes-node-91a76fc.ash1-iad.github.net [10.56.119.14]) by smtp.github.com (Postfix) with ESMTPA id E183C9025B1 for <quic-issues@ietf.org>; Fri, 30 Oct 2020 08:13:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1604070789; bh=uKqwHC3Q/r/vIiK7pXCrhtJ6gYcL3pka01pjDoqSzrw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=T3VRS0YPhXOZRupEdSTVpESs4su0ozHhfp3FrXnVi8dc/mEx4YkBSIguhI4ca/szN Eiw7raXobJez68q+hKttjTSCZDRM2oenJeaNQWV9Czd+1ziJeYl2/cenKAq2T1TStM wwDTrpUbz/8mqZpViLVqAqVyhJwOkqS1wscTvlZQ=
Date: Fri, 30 Oct 2020 08:13:09 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3CXZDSGAFXUV3HFYN5VAHILEVBNHHCXKDAWA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4316/review/520764770@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4316@github.com>
References: <quicwg/base-drafts/pull/4316@github.com>
Subject: Re: [quicwg/base-drafts] VarInt decoding pseudocode (#4316)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f9c2d85ddfc9_3719b4194073"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0_bRDQVpLaUrU-7CkDkFsU9dPj0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Oct 2020 15:13:12 -0000

@MikeBishop commented on this pull request.



> +read from a stream of bytes.  The function ReadVarint takes a single argument, a
+sequence of bytes which can be read in network byte order.
+
+~~~
+ReadVarint(data):
+  // The length of variable-length integers is encoded in the
+  // first two bits of the first byte.
+  v = data.next_byte()
+  length = (1 << (v >> 6))
+
+  // Once the length is known, remove these bits and read any
+  // remaining bytes.
+  v = v & 0x3f
+  repeat length-1 times:
+    v = (v << 8) + data.next_byte()
+  return v

Yes, but I'm not sure that's necessary to mention.  We haven't changed it over the course of the algorithm.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4316#discussion_r515170570