Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)

Martin Thomson <notifications@github.com> Wed, 16 January 2019 21:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE2581311AE for <quic-issues@ietfa.amsl.com>; Wed, 16 Jan 2019 13:34:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nLBKiFrW1JTy for <quic-issues@ietfa.amsl.com>; Wed, 16 Jan 2019 13:34:49 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 253771311A7 for <quic-issues@ietf.org>; Wed, 16 Jan 2019 13:34:49 -0800 (PST)
Date: Wed, 16 Jan 2019 13:34:47 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547674487; bh=KmWzkvErpRoTEKdNLDYLXvNBBLZqWrOY3DxOPUEjLjY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uWzIxMKt9XYSv2gnk+C49OW2v+aJA4coBnjxv7zM18pzErzoW00nkFoAelHB3Ats7 mUOCFyJ8tcLmG22jz1INqKWPDaPV9bF5eeojsuRh8vl59dLiaQa6R12pgl7q1+CgPL D/jy+PvVdWh5iG804YwS0jo26CFyWDC0+ht7jJ30=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab22d17f77fdbc15adc551b1a01223f23c9d488af492cf000000011857657792a169ce17b2473c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2327/review/193363460@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2327@github.com>
References: <quicwg/base-drafts/pull/2327@github.com>
Subject: Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3fa377d1b8a_49f33fc6020d45b425386f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0myenKghmV8GTxsY8KjWqq77RDE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2019 21:34:51 -0000

martinthomson commented on this pull request.



> @@ -945,6 +973,14 @@ The recovery period limits congestion window reduction to once per round trip.
 During recovery, the congestion window remains unchanged irrespective of new
 losses or increases in the ECN-CE counter.
 
+#### Ignoring Loss of Undecryptable Packets

I think that you want H2 here, definitely not H4.

```suggestion
## Ignoring Loss of Undecryptable Packets
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2327#pullrequestreview-193363460