Re: [quicwg/base-drafts] Allow removal of ACK blocks that are in flight (#917)
Mike Bishop <notifications@github.com> Sun, 12 November 2017 14:13 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4EB8D129440 for <quic-issues@ietfa.amsl.com>; Sun, 12 Nov 2017 06:13:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.8
X-Spam-Level:
X-Spam-Status: No, score=-4.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VBVFBlbJ_xRc for <quic-issues@ietfa.amsl.com>; Sun, 12 Nov 2017 06:13:53 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46F3A1200F1 for <quic-issues@ietf.org>; Sun, 12 Nov 2017 06:13:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ekuy+QWi+1njYmDJnM5x4cztjqo=; b=BUowJnDKu3xuQG2w uC0S/Yp9B3KKhpgbQ+D97w5l6nPCRRYlxzMao12ZoJaKhu4rOCW1KG0nC2oYot1Y zGk5Slk011nfFNztwbIME7+31hujmPgsCZrUVTxa6+E0PiqWxWDas9tcbsQrp5zC R2vpleoFmtLt16V+V+eJmxSye5c=
Received: by filter0397p1iad2.sendgrid.net with SMTP id filter0397p1iad2-21143-5A085720-2 2017-11-12 14:13:52.025985348 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0004p1iad2.sendgrid.net (SG) with ESMTP id Q0nOmrq2RJ-chGyP8M6EyA for <quic-issues@ietf.org>; Sun, 12 Nov 2017 14:13:52.234 +0000 (UTC)
Date: Sun, 12 Nov 2017 14:13:52 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abea31bf58fdebb10b77bb066f141e8a04e43746ff92cf000000011620192092a169ce1048c429@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/917/343740140@github.com>
In-Reply-To: <quicwg/base-drafts/issues/917@github.com>
References: <quicwg/base-drafts/issues/917@github.com>
Subject: Re: [quicwg/base-drafts] Allow removal of ACK blocks that are in flight (#917)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a0857201fcb5_2a003fd1b1b8cf28220347c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
tracking:
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3ccKwkAts4SP/+QafYT/pYHbUzlt9nz08v1Y SHyv0oy+QwHFCB2jU4gEibTJJ1d6V3VDEkorPvSvurjaW1Yl9/dhfQdG/Ow4BAqg6/o5T0TymsHS43 NWGqLjbjAtDqLeqVFHeWQ31rG+SUPHSjONlkGVYJTaDSXx1nyaCGjbOmRgRRK4L8o2k1t5VchqoI9V A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0nqpdTJzRS5-ZSrwxz5p3eJJLkE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Nov 2017 14:13:55 -0000
Can you help me understand the pathological case when something is ACK’d, omitted, then ACK’d again? If the original ACK gets through, the sender should ignore the second one. If the original ACK gets lost, it looks to the sender like a severely delayed packet and it will realize the retransmission was spurious (if it still has data), but might update the congestion controller with the un-loss event. That doesn’t seem so bad at first glance. From: ianswett [mailto:notifications@github.com] Sent: Sunday, November 12, 2017 4:42 PM To: quicwg/base-drafts <base-drafts@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [quicwg/base-drafts] Allow removal of ACK blocks that are in flight (#917) I think the existing text is mostly sufficient(though I realize it's a bit redundant at the moment, which I'll fix). I really do not advise some clever scheme where you send an ack block once and then then stop sending it for some arbitrary period of time and then start again, so I don't want to write text implying I'd recommend it. There is still work to be done to add more discussion of when to send acknowledgements and what to include in them, but it was decided in Seattle that the transport draft should focus on the boundaries of what the receiver should do and the recovery draft can discuss the nuances and optimizations that are possible with considerations about their pros and cons. That work is tracked in #230<https://github.com/quicwg/base-drafts/issues/230> "To limit receiver state or the size of ACK frames, a receiver MAY limit the number of ACK blocks it sends. A receiver can do this even without receiving acknowledgment of its ACK frames, with the knowledge this could cause the sender to unnecessarily retransmit some data. When this is necessary, the receiver SHOULD acknowledge newly received packets and stop acknowledging packets received in the past. Removing ack blocks before the peer has received them increases the chances the peer never received an acknowledgement, will declare the packet lost, and spuriously retransmit information." — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://github.com/quicwg/base-drafts/issues/917#issuecomment-343722015>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEE2hYPDupg70sZEpl27EPsg_D_5t6POks5s1q9ugaJpZM4Qaw74>. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/917#issuecomment-343740140
- [quicwg/base-drafts] Allow removal of ACK blocks … Martin Thomson
- Re: [quicwg/base-drafts] Allow removal of ACK blo… MikkelFJ
- Re: [quicwg/base-drafts] Allow removal of ACK blo… ianswett
- Re: [quicwg/base-drafts] Allow removal of ACK blo… Mike Bishop
- Re: [quicwg/base-drafts] Allow removal of ACK blo… MikkelFJ
- Re: [quicwg/base-drafts] Allow removal of ACK blo… ianswett
- Re: [quicwg/base-drafts] Allow removal of ACK blo… Mike Bishop
- Re: [quicwg/base-drafts] Allow removal of ACK blo… ianswett
- Re: [quicwg/base-drafts] Allow removal of ACK blo… Mike Bishop
- Re: [quicwg/base-drafts] Allow removal of ACK blo… ianswett
- Re: [quicwg/base-drafts] Allow removal of ACK blo… MikkelFJ
- Re: [quicwg/base-drafts] Allow removal of ACK blo… ianswett
- Re: [quicwg/base-drafts] Allow removal of ACK blo… Martin Thomson
- Re: [quicwg/base-drafts] Allow removal of ACK blo… Martin Thomson