Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)

martinduke <notifications@github.com> Fri, 28 February 2020 00:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 592C13A09A3 for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 16:13:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NKHmV5mMDn3f for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 16:13:12 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DCF773A099E for <quic-issues@ietf.org>; Thu, 27 Feb 2020 16:13:11 -0800 (PST)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id DBF13660918 for <quic-issues@ietf.org>; Thu, 27 Feb 2020 16:13:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582848790; bh=mo+doVXbZAxitJ96UKj546THx95rdoZfUKiLM5K7KOI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rVZryUAs1Jri42kw3OF9XNRN560OLVXL+X67XW0oAmepC4c3zL98U3ywnCszV91Ma 9F9nheESDun76bwTm2kMQRl7LMbbYCv/A3Gtgp32rjqCH0XX1uOzPdNXSaWbDQydK9 suduaS8Njn7ZDNMmDTgVdGR6UkLEZdoQ9heIqrk0=
Date: Thu, 27 Feb 2020 16:13:10 -0800
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7AY3WHFGIFNDF44ZN4MWGZNEVBNHHCEHSQ2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3486/review/366087300@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3486@github.com>
References: <quicwg/base-drafts/pull/3486@github.com>
Subject: Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e585b16cb3fd_4be83fc18cacd9641845ab"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0qXxneYZiv4JxfQvwoLK8rGB008>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2020 00:13:13 -0000

martinduke requested changes on this pull request.



> @@ -476,9 +476,10 @@ When ack-eliciting packets are in-flight in multiple packet number spaces,
 the timer MUST be set for the packet number space with the earliest timeout,
 except for ApplicationData, which MUST be ignored until the handshake
 completes; see Section 4.1.1 of {{QUIC-TLS}}.  Not arming the PTO for
-ApplicationData prioritizes completing the handshake and prevents the server
-from sending a 1-RTT packet on a PTO before before it has the keys to process
-a 1-RTT packet.
+ApplicationData prioritizes completing the handshake and prevents the client

Just to clarify a bit more and clean up the run-on sentence.

ApplicationData prioritizes completing the handshake, prevents the client
from sending a 0-RTT packet on a PTO before it knows the server has accepted
0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before
before it has the keys to process a 1-RTT acknowledgment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3486#pullrequestreview-366087300