Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)
Mike Bishop <notifications@github.com> Wed, 26 September 2018 18:33 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0DB33130E09 for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 11:33:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0S-HP98lQ_-e for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 11:33:33 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AF53D128766 for <quic-issues@ietf.org>; Wed, 26 Sep 2018 11:33:33 -0700 (PDT)
Date: Wed, 26 Sep 2018 11:33:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537986812; bh=vQYj4XaSpryzkDjEaXKvEVvm3yLQkfCj+g/hlfSF028=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=IXuufDJ8b/V+8JgxxacEU3oCX/8wMeBYAQb9xBref+tmGkozc6q/EC4OjYETAF/80 vh+F08Xca8rLAnr5d6RO6EM32rvvsuk2r8cTTTdKHsWLTyXknEpKdnTakNL0dgV+Bo ZQTURt8wSv7U//JxxkvLGRU1M65M5/jr5ZQ1rZXM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8da130ecf4ded46af93ab4e6efc1bf6842f53e8d92cf0000000117c392fc92a169ce158602f3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1762/review/159139221@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1762@github.com>
References: <quicwg/base-drafts/pull/1762@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5babd0fc827c7_670e3fa2088d45c022301a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0uqVSuB1yMVpAN4djTebbVk_fXU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 18:33:36 -0000
MikeBishop approved this pull request. This is fine, but one suggestion for readability. "...greater than the number of dynamic table entries beyond the current Largest Known Received" is correct, but not immediately comprehensible. Maybe framing that as "...which indicates receipt of an entry which has not been sent" would help it be obvious why that number is a problem? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1762#pullrequestreview-159139221
- [quicwg/base-drafts] QPACK: make TSS=0 a connecti… afrind
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… afrind
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… Mike Bishop
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… afrind
- Re: [quicwg/base-drafts] QPACK: make TSS=0 a conn… afrind