Re: [quicwg/base-drafts] Migration with zero-length CID is inadvisable (#3563)

ekr <notifications@github.com> Fri, 08 May 2020 20:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43D2B3A0ECA for <quic-issues@ietfa.amsl.com>; Fri, 8 May 2020 13:23:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o4SFnTxByBBl for <quic-issues@ietfa.amsl.com>; Fri, 8 May 2020 13:23:00 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68A1A3A0F4C for <quic-issues@ietf.org>; Fri, 8 May 2020 13:22:22 -0700 (PDT)
Received: from github-lowworker-0f7e7fd.ash1-iad.github.net (github-lowworker-0f7e7fd.ash1-iad.github.net [10.56.110.17]) by smtp.github.com (Postfix) with ESMTP id 18834521D92 for <quic-issues@ietf.org>; Fri, 8 May 2020 13:22:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588969339; bh=h2isi7ZlwZjsutYjl8cOmCSEL6+/42MyB+DIuaFTZ5I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Okrh3/FAFCKMJWnsmUUZI4NXnk1rUu17h2p3BuasHoJ58cx7bqQLwDfoMjd5U7Hg9 2ZE4JseXcm0AeEo7PMsmqUhlrJG9UpBkiRpAWYOV/DVyPNp3/Sel2ZaQGk+vkc/3Gs p0MvEgRq5VSNyEwFhMkVtE4VQ2+3XFYwWETdhlEw=
Date: Fri, 08 May 2020 13:22:19 -0700
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYV26RYADGSCZRGMJN4YGQHVEVBNHHCGQM7OQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3563/review/408501768@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3563@github.com>
References: <quicwg/base-drafts/pull/3563@github.com>
Subject: Re: [quicwg/base-drafts] Migration with zero-length CID is inadvisable (#3563)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eb5bf7b6cd4_615d3fd9a4ecd96c48922"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1Ap3kwZj-fGb8sPYWwvisOt0DqA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 May 2020 20:24:10 -0000

@ekr approved this pull request.



> @@ -2246,6 +2246,16 @@ that packet numbers cannot be used to correlate activity.  This does not prevent
 other properties of packets, such as timing and size, from being used to
 correlate activity.
 
+An endpoint SHOULD NOT initiate migration with a peer that uses a zero-length

```suggestion
An endpoint SHOULD NOT initiate migration with a peer that has requested a zero-length
```

> @@ -2246,6 +2246,16 @@ that packet numbers cannot be used to correlate activity.  This does not prevent
 other properties of packets, such as timing and size, from being used to
 correlate activity.
 
+An endpoint SHOULD NOT initiate migration with a peer that uses a zero-length

"uses" is confusing here. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3563#pullrequestreview-408501768