Re: [quicwg/base-drafts] Forbid use of application-level close in Initial, Handshake packets (#3164)

Martin Thomson <notifications@github.com> Tue, 29 October 2019 22:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22925120072 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 15:21:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BtLBDzqCZ5zn for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 15:21:14 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A94212001E for <quic-issues@ietf.org>; Tue, 29 Oct 2019 15:21:14 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 75AE0C607FE for <quic-issues@ietf.org>; Tue, 29 Oct 2019 15:21:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572387673; bh=moTMCvKk4AZxlF15aVFNQfYHZQpb+GbjjmIk+tE/nLM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sM+qYJyN2GFGh7JpdZIEQSsBFS2Cf5BLMCLaoCZfdebchp6OE/IaIssxq+56mVvp2 vONH9a5DOkLfkdYGSIo9PKXzmBzFIU7dos3lqvAC2lUmB4BBJVnXiH6Oc2BF2LRPxx WA2L86eqGq/Z1gC+ame8fRYzRfwt122ddl1uaUAM=
Date: Tue, 29 Oct 2019 15:21:13 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5VSUHJZK23AQWEPEN3YXW5TEVBNHHB5HMNYI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3164/review/308863025@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3164@github.com>
References: <quicwg/base-drafts/pull/3164@github.com>
Subject: Re: [quicwg/base-drafts] Forbid use of application-level close in Initial, Handshake packets (#3164)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8bb596675a_4b213ff93fecd95c3958d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1FewEK2ZatzMre01zvcSBDhfZAI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 22:21:16 -0000

martinthomson approved this pull request.



> @@ -5503,6 +5503,12 @@ Reason Phrase:
   zero length if the sender chooses to not give details beyond the Error Code.
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
+The application-specific variant of CONNECTION_CLOSE (type 0x1d) can only be
+sent using an 1-RTT packet ({{QUIC-TLS}}; section 4).  An application can close

```suggestion
sent using an 1-RTT packet ({{QUIC-TLS}}, Section 4).  An application can close
```

> @@ -5503,6 +5503,12 @@ Reason Phrase:
   zero length if the sender chooses to not give details beyond the Error Code.
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
+The application-specific variant of CONNECTION_CLOSE (type 0x1d) can only be
+sent using an 1-RTT packet ({{QUIC-TLS}}; section 4).  An application can close
+the connection during the handshake by sending a CONNECTION_CLOSE frame (type
+0x1c) with an error code of 0x15a ("user_canceled" alert; see {{?TLS13}}) in an
+Initial or a Handshake packet.

Is this "An application that wishes to abandon a connection during the handshake [...]"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3164#pullrequestreview-308863025