Re: [quicwg/base-drafts] Rearrange discussion of cancellation and rejection (#3926)

Martin Thomson <notifications@github.com> Thu, 23 July 2020 02:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2F18A3A0B57 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 19:18:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1_mg4iZoRPoL for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 19:18:09 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53C0A3A0B51 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 19:18:09 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id A3B348C0CE2 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 19:18:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595470688; bh=5TlimT5s1pvuE1RKNKIiRZOnvD3pT2QuCKFy9X/K1qI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=B39hHERMmTZcngNnHdlywQ7Q54ZKPUYLgU9cxLZJyjkkwPmIwOmSEXVKvkNy19OgC RqBKLKVpVyXJtK2SD7WL+D33Iz6l4tqIugeLw0tCCVai9TstWyFO7lAIALGEOIPeqN FRcKgz3Gp+gEPIyos6dhDXFeCcspghvCI+ioyQyk=
Date: Wed, 22 Jul 2020 19:18:08 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7KUBZ2W7X57UHFRFN5ETKGBEVBNHHCPCDOBQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3926/review/452864917@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3926@github.com>
References: <quicwg/base-drafts/pull/3926@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange discussion of cancellation and rejection (#3926)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f18f36090f9d_6dc13fbe3eccd96828121"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1GmlQ0_dI_oj3FOtNHWL-ih1fqg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 02:18:11 -0000

@martinthomson approved this pull request.



> +requests if they are unable to or choose not to respond.  When possible, it is
+RECOMMENDED that servers send an HTTP response with an appropriate status code
+rather than canceling a request it has already begun processing.
+
+Implementations SHOULD cancel requests by abruptly terminating any
+directions of a stream that are still open.  This means resetting the
+sending parts of streams and aborting reading on receiving parts of streams;
+see Section 2.4 of [QUIC-TRANSPORT].
+
+When the server cancels a request without performing any application processing,
+the request is considered "rejected."  The server SHOULD abort its response
+stream with the error code H3_REQUEST_REJECTED. In this context, "processed"
+means that some data from the stream was passed to some higher layer of software
+that might have taken some action as a result. The client can treat requests
+rejected by the server as though they had never been sent at all, thereby
+allowing them to be retried later on a new connection. Servers MUST NOT use the

```suggestion
allowing them to be retried later. Servers MUST NOT use the
```

> +possible, it is RECOMMENDED that servers send an HTTP response with an
+appropriate status code rather than canceling a request it has already begun
+processing.
+
+Implementations SHOULD cancel requests by abruptly terminating any
+directions of a stream that are still open.  This means resetting the
+sending parts of streams and aborting reading on receiving parts of streams;
+see Section 2.4 of [QUIC-TRANSPORT].
+
+When the server cancels a request without performing any application processing,
+the request is considered "rejected."  The server SHOULD abort its response
+stream with the error code H3_REQUEST_REJECTED. In this context, "processed"
+means that some data from the stream was passed to some higher layer of software
+that might have taken some action as a result. The client can treat requests
+rejected by the server as though they had never been sent at all, thereby
+allowing them to be retried later. Servers MUST NOT use the H3_REQUEST_REJECTED

```suggestion
allowing them to be retried later.

Servers MUST NOT use the H3_REQUEST_REJECTED
```

This seems like a good point to break this mega-paragraph.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3926#pullrequestreview-452864917