Re: [quicwg/base-drafts] Tweaks to more closely match RFC Editor XML (PR #4958)

Martin Thomson <notifications@github.com> Thu, 17 February 2022 23:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1906D3A13C0 for <quic-issues@ietfa.amsl.com>; Thu, 17 Feb 2022 15:01:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.262
X-Spam-Level:
X-Spam-Status: No, score=-7.262 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.576, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BRMb500qDd_D for <quic-issues@ietfa.amsl.com>; Thu, 17 Feb 2022 15:01:28 -0800 (PST)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6FFA3A13BD for <quic-issues@ietf.org>; Thu, 17 Feb 2022 15:01:28 -0800 (PST)
Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id 7F9ED9034A5 for <quic-issues@ietf.org>; Thu, 17 Feb 2022 15:01:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1645138887; bh=ED7blH22tmV3YwlvUn7LuSAtEXXekuOqR8fhYq5lTT0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bh9CRvIIIubLh5Rc0or3YUWSzW3yLkvUQVOpkR8ibDYU4s7ObxiTLt/VfwpoGPU58 DGDS5jP919VkfQvalZdTbVQhUo2emmWMoL57Qq0dawzUx547aEveM2L2D0ccYmZXsA N2sySHFnfuF/ZUVhuPRKA8z/JmGqRozh5qAc7//s=
Date: Thu, 17 Feb 2022 15:01:27 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK235ZFDNMVZTSXFRNGADK2MPEVBNHHEIDWSBE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4958/review/886653234@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4958@github.com>
References: <quicwg/base-drafts/pull/4958@github.com>
Subject: Re: [quicwg/base-drafts] Tweaks to more closely match RFC Editor XML (PR #4958)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_620ed3c770ff5_5f8dc6fc17158"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1Ix05jZ_Xlh3j49x3FTpwL15VN8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Feb 2022 23:01:33 -0000

@martinthomson commented on this pull request.

I went the other way when it came to figure references, but this is fine.

> @@ -1219,8 +1217,8 @@ H3_ID_ERROR; see {{errors}}.
 
 ### Reserved Stream Types {#stream-grease}
 
-Stream types of the format 0x1f * N + 0x21 for non-negative integer values of N
-are reserved to exercise the requirement that unknown types be ignored. These
+Stream types of the format `0x1f * N + 0x21` for non-negative integer values of
+N are reserved to exercise the requirement that unknown types be ignored. These

Do you want "\`N\`" here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4958#pullrequestreview-886653234
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4958/review/886653234@github.com>