IETF Logo Mail Archive

Re: [quicwg/base-drafts] Martin Duke's QPACK comments (#4750)

afrind <notifications@github.com> Tue, 19 January 2021 23:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C92F3A1870 for <quic-issues@ietfa.amsl.com>; Tue, 19 Jan 2021 15:12:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.823
X-Spam-Level:
X-Spam-Status: No, score=-1.823 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sgyVo4dKjnnU for <quic-issues@ietfa.amsl.com>; Tue, 19 Jan 2021 15:12:53 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 381CE3A0C44 for <quic-issues@ietf.org>; Tue, 19 Jan 2021 15:12:53 -0800 (PST)
Received: from github.com (hubbernetes-node-a87f560.ash1-iad.github.net [10.56.110.66]) by smtp.github.com (Postfix) with ESMTPA id 77A2F900768 for <quic-issues@ietf.org>; Tue, 19 Jan 2021 15:12:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611097972; bh=6RpR4URS/1LUAD0SifIbAKb+AzhkMKewMZSe8rJdv5U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rq4GxTHijeX3np5ZszyFeS3vNc550ZVULofqtKN5VJDL3pgYTD6M5L2dE/gUzvXD7 4z5oPj6h1WuQsnawhMWCyi/k1uQwagKc9oX3kVw15uB4aqbbm2z8PgxEtlyrO3o3SX FZW4kRwluZVki8DOGYgFIYWS9exqUo5jPYN3ZPJE=
Date: Tue, 19 Jan 2021 15:12:52 -0800
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ2NQ2DE6WVMLGRZY56CNEHJEVBNHHC6CKWHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4750/review/571743341@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4750@github.com>
References: <quicwg/base-drafts/pull/4750@github.com>
Subject: Re: [quicwg/base-drafts] Martin Duke's QPACK comments (#4750)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_6007677474944_4bc1a04841e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1JkCuPnQ2V5AwaEuVKfZlAIdrg4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2021 23:12:55 -0000

@afrind commented on this pull request.



> +first-out order.  Each QPACK decoder holds a dynamic table that is initially
 empty.  Entries are added by encoder instructions received on the encoder
-stream; see {{encoder-instructions}}.
+stream; see {{encoder-instructions}}.  The encoder tracks the contents of the
+dynamic table maintained by the decoder.

I think it's slightly odd to say that the encoder tracks the decoder, when in practice the encoder is doing the inserts and uses it for compression.  Let me think a bit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4750#pullrequestreview-571743341

v2.23.0 | Report a Bug | By Email