IETF Logo Mail Archive

Re: [quicwg/base-drafts] If PTO is armed for anti-deadlock, use now() (#3556)

ianswett <notifications@github.com> Tue, 31 March 2020 18:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E5E73A270F for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 11:28:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jfOCg0Y_R9Dm for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 11:28:22 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42BAC3A26E9 for <quic-issues@ietf.org>; Tue, 31 Mar 2020 11:28:17 -0700 (PDT)
Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id AE92FE020E for <quic-issues@ietf.org>; Tue, 31 Mar 2020 11:28:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585679295; bh=6S4ZA5t27dgM1W9u5LcYxzV2TA5gDwe9p6X945ynyiM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OnvLifiQLOlEFy/yF9dSA/xJBQidegRnmey44eF0pgdGX7qH0KMWLc7Nl4cbinkjG Xe/u8mRkGs3bhqT7gYcHYxWJ+yvN1HSf9LLHSsuHtHtmjpj76STi8TJS1aQALYtqLC jkyJuwEs3QjYEQPm0BieNzJtsuIuoeWZlF4WHlkI=
Date: Tue, 31 Mar 2020 11:28:15 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6ZFWEYPLUWDQ5M3TN4R5WL7EVBNHHCGL7MQU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3556/review/384995471@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3556@github.com>
References: <quicwg/base-drafts/pull/3556@github.com>
Subject: Re: [quicwg/base-drafts] If PTO is armed for anti-deadlock, use now() (#3556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e838bbf9e3a5_225a3fa41b6cd9601500b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1K79Q8i6AdOEUvoNu4MoxpTbBSM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 18:28:31 -0000

@ianswett commented on this pull request.



> +  if (sent_time == 0)
+    assert(!PeerNotAwaitingAddressValidation())
+    sent_time = now()
   loss_detection_timer.update(sent_time + timeout)

I'm worried that's too clever.  This is a special case, but so are many things about the anti-deadlock functionality, unfortunately.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3556#discussion_r401124460

v2.23.0 | Report a Bug | By Email