Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id D2856130DF1
 for <quic-issues@ietfa.amsl.com>; Tue, 13 Nov 2018 11:46:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level: 
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001,
 MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 2OcinyABlVOA for <quic-issues@ietfa.amsl.com>;
 Tue, 13 Nov 2018 11:46:35 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 11057130DE0
 for <quic-issues@ietf.org>; Tue, 13 Nov 2018 11:46:35 -0800 (PST)
Date: Tue, 13 Nov 2018 11:46:34 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1542138394;
 bh=gt38bDl/Jxn27G7dwsnfcgNTjz3CC9tbKX7XcEXJcnA=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=12Cmsyi5yyfPAEIOAOFvspaCDsC+uIt1ELe1kogWTy4x1FWFsqjqklkZrggFtBT8n
 LfmeeUBLPuD9EVC48DmGhirCSOyU3EOigAGwuBwZVBgrsX6Tpt140MKJwPe5FtQQmz
 yYA8+SYRHdlCVx1t4qKRC3bMuJJKa3M9jX67ELOE=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abed67d0ae8115026c080c450e2ca018001066b2e892cf000000011802ec1a92a169ce168acaf3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1978/438410558@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1978@github.com>
References: <quicwg/base-drafts/issues/1978@github.com>
Subject: Re: [quicwg/base-drafts] Sender-Controlled Delayed ACK Ratio (#1978)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5beb2a1a5dfb_24d3fdca18d45c4106929";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1KQuxgb3U3VC_ejmqnPeYe541Ws>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Nov 2018 19:46:37 -0000


----==_mimepart_5beb2a1a5dfb_24d3fdca18d45c4106929
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@janaiyengar , if we're not going to add a generic UPDATE_TRANSPORT_PARAMs frame, then I think it makes more sense to ONLY have an UPDATE_ACK_RATIO/DELAY/etc frame and not add any new transport params, since I think what we have now is good enough to complete the handshake?

I'm favoring adding the ability to update two params:
1) MaxAckDelay (default 25ms)
2) MaxPacketsBeforeAck (currently always 2) - aka how many packets can be received before sending an acknowledgement.

Even though gQUIC has had success with fraction of RTT, I think it's less robust than specifying an actual amount of time, and specifying an amount of time allows for more precise TLP and RTO timeouts, which is very nice.

I agree there need to be bounds on how small an ack delay a sender can request and how small a MaxPacketsBeforeAck?  I'd prefer a hard failure(ie: connection close) to a "I'm just not going to do what you ask and not tell you", so I'd prefer a transport param or other mechanism to communicate the MinMaxAckDelay for a connection and a rule that you can't request a MaxPacketsBeforeAck smaller than 2.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1978#issuecomment-438410558
----==_mimepart_5beb2a1a5dfb_24d3fdca18d45c4106929
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><a class=3D"user-mention" data-hovercard-type=3D"user" data-hovercard-=
url=3D"/hovercards?user_id=3D11067604" data-octo-click=3D"hovercard-link-=
click" data-octo-dimensions=3D"link_type:self" href=3D"https://github.com=
/janaiyengar">@janaiyengar</a> , if we're not going to add a generic UPDA=
TE_TRANSPORT_PARAMs frame, then I think it makes more sense to ONLY have =
an UPDATE_ACK_RATIO/DELAY/etc frame and not add any new transport params,=
 since I think what we have now is good enough to complete the handshake?=
</p>
<p>I'm favoring adding the ability to update two params:</p>
<ol>
<li>MaxAckDelay (default 25ms)</li>
<li>MaxPacketsBeforeAck (currently always 2) - aka how many packets can b=
e received before sending an acknowledgement.</li>
</ol>
<p>Even though gQUIC has had success with fraction of RTT, I think it's l=
ess robust than specifying an actual amount of time, and specifying an am=
ount of time allows for more precise TLP and RTO timeouts, which is very =
nice.</p>
<p>I agree there need to be bounds on how small an ack delay a sender can=
 request and how small a MaxPacketsBeforeAck?  I'd prefer a hard failure(=
ie: connection close) to a "I'm just not going to do what you ask and not=
 tell you", so I'd prefer a transport param or other mechanism to communi=
cate the MinMaxAckDelay for a connection and a rule that you can't reques=
t a MaxPacketsBeforeAck smaller than 2.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/issues/1978#issuecomment-438410558">view it on GitHub</a>,=
 or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkqws2=
K3Tn1PcLTSx3Z86mLvBssTwoks5uuyGagaJpZM4YSA-X">mute the thread</a>.<img sr=
c=3D"https://github.com/notifications/beacon/AWbkq8yRFurlP27eQ3pQlbZXMIeo=
PAhvks5uuyGagaJpZM4YSA-X.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ians=
wett in #1978: @janaiyengar , if we're not going to add a generic UPDATE_=
TRANSPORT_PARAMs frame, then I think it makes more sense to ONLY have an =
UPDATE_ACK_RATIO/DELAY/etc frame and not add any new transport params, si=
nce I think what we have now is good enough to complete the handshake?\r\=
n\r\nI'm favoring adding the ability to update two params:\r\n1) MaxAckDe=
lay (default 25ms)\r\n2) MaxPacketsBeforeAck (currently always 2) - aka h=
ow many packets can be received before sending an acknowledgement.\r\n\r\=
nEven though gQUIC has had success with fraction of RTT, I think it's les=
s robust than specifying an actual amount of time, and specifying an amou=
nt of time allows for more precise TLP and RTO timeouts, which is very ni=
ce.\r\n\r\nI agree there need to be bounds on how small an ack delay a se=
nder can request and how small a MaxPacketsBeforeAck?  I'd prefer a hard =
failure(ie: connection close) to a \"I'm just not going to do what you as=
k and not tell you\", so I'd prefer a transport param or other mechanism =
to communicate the MinMaxAckDelay for a connection and a rule that you ca=
n't request a MaxPacketsBeforeAck smaller than 2."}],"action":{"name":"Vi=
ew Issue","url":"https://github.com/quicwg/base-drafts/issues/1978#issuec=
omment-438410558"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/1978#issuecomment=
-438410558",
"url": "https://github.com/quicwg/base-drafts/issues/1978#issuecomment-43=
8410558",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Sender-Controlled Delayed ACK Ratio (#=
1978)",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \=
"quicwg/base-drafts\",\n\"issueId\": 1978,\n\"IssueComment\": \"{{IssueCo=
mment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"q=
uicwg/base-drafts\",\n\"issueId\": 1978\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/issues/1978#issuecomment-43=
8410558"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 4073757=
67\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5beb2a1a5dfb_24d3fdca18d45c4106929--

