From nobody Tue Mar 10 16:00:37 2020
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 1DF9C3A08A6
 for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 16:00:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level: 
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 0jICYSHx79Cn for <quic-issues@ietfa.amsl.com>;
 Tue, 10 Mar 2020 16:00:29 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 9A2213A0887
 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 16:00:29 -0700 (PDT)
Date: Tue, 10 Mar 2020 16:00:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1583881228;
 bh=m1/fAu6J2HMWz/E6osgkm4FnvLzYffIt2uV7sd6/Gbo=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=WkTTFKfI/tMalfUkVmkQSoWNkYBroNtkpr2fDd5EjR2CHx5veoSboWxpeO8YF/OJD
 52xhOsj+OiNhiAtJd/4wAS0Qd5cQ7sBBoQIIjMDsw0lW9p+lkey/Im/ai0i770c2vY
 dE+wwS0npVPSSVh69OgNPu+xPCiFXzh+zzIRVciw=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7NBJVN77OFX2ZGWCN4OP6QZEVBNHHCEHSQ2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3486/review/372377964@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3486@github.com>
References: <quicwg/base-drafts/pull/3486@github.com>
Subject: Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData
 before completion (#3486)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e681c0cabfae_4b983f98018cd95c127097";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1OJYRaufBeBlT-4NwKne6y3m-Ec>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2020 23:00:37 -0000


----==_mimepart_5e681c0cabfae_4b983f98018cd95c127097
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar commented on this pull request.



> +and prevents a server from sending a 1-RTT packet on a PTO expiration before it
+has the keys to process an acknowledgement.

```suggestion
and it also prevents a server from sending a 1-RTT packet on a PTO expiration
before it has the keys to process an acknowledgement.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3486#pullrequestreview-372377964
----==_mimepart_5e681c0cabfae_4b983f98018cd95c127097
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@janaiyengar</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3486#discussi=
on_r390659296">draft-ietf-quic-recovery.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; +and prevents a server from sending a 1-RT=
T packet on a PTO expiration before it=0D
+has the keys to process an acknowledgement.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-and prevents a server from sending a 1-RTT pa=
cket on a PTO expiration before it=0D
-has the keys to process an acknowledgement.=0D
+and it also prevents a server from sending a 1-RTT packet on a PTO expir=
ation=0D
+before it has the keys to process an acknowledgement.=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3486?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK5BSKJP2Z4AI2BV4CLRG3BAZA5CNFSM4K5E5VMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYZAS3A#pullrequestreview-372377964=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK55SQBYOPIP4ZFCULLRG3BAZANCNFSM4K5E5VMA">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK3SVSPRV7QM=
EOZZ5LDRG3BAZA5CNFSM4K5E5VMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCYZAS3A.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3486?email_source=3D=
notifications\u0026email_token=3DAFTOJK5BSKJP2Z4AI2BV4CLRG3BAZA5CNFSM4K5E=
5VMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
YZAS3A#pullrequestreview-372377964",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3486?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK5BSKJP2Z4AI2BV4CLRG3BAZA5CNFSM4K5E5V=
MKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYZ=
AS3A#pullrequestreview-372377964",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5e681c0cabfae_4b983f98018cd95c127097--

