Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)

ianswett <notifications@github.com> Mon, 30 July 2018 13:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E87DF1310C2 for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 06:28:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zcfMMA8wZuaj for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 06:28:43 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C6B11310BF for <quic-issues@ietf.org>; Mon, 30 Jul 2018 06:28:43 -0700 (PDT)
Date: Mon, 30 Jul 2018 06:28:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532957322; bh=tbkJJzdrD7d/6JTF2b3728PbpOqLDTlY2Zw5qrJ0LWY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZeJlNLe99O7eGMaMpGi852m40RTQj0XSkWzgX0fYjikLdeOdPCjJ6iSdeuckhFYm1 at4ZqpmQZClYFg7j6r+3oKZsgBb7M5Zpg5Zr3fzY/wQOgsNXICev5MNs+WSH2wOgBm D/yBv/oa0tgW6QrjfGJth/hNV2qVsqBpR4xgxch0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab27196cb37107ea0ad6c2982caa2da8cf13af996692cf000000011776d48a92a169ce1461f5c3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1574/review/141531803@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1574@github.com>
References: <quicwg/base-drafts/pull/1574@github.com>
Subject: Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5f128a27928_5a5c3ff6cc8d45c017057a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1Un1p5MXD7IwMkOmsoqX6g0Sokg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2018 13:28:45 -0000

ianswett commented on this pull request.



> @@ -206,6 +206,19 @@ Min RTT is the minimum RTT measured over the connection, prior to adjusting by
 ack delay.  Ignoring ack delay for min RTT prevents intentional or unintentional
 underestimation of min RTT, which in turn prevents underestimating smoothed RTT.
 
+### Maximum Ack Delay
+
+QUIC is able to explicitly model delay at the receiver via the ack delay
+field in the ACK frame.  Therefore, QUIC diverges from TCP by calculating a
+MaxAckDelay dynamically, instead of assuming a constant delayed ack timeout
+for all connections.
+
+MaxAckDelay is the maximum ack delay supplied in an all incoming ACK frames.
+MaxAckDelay excludes ack delays that aren't included in an RTT sample because
+they're too large or the largest acked has already been acknowledged.
+MaxAckDelay also excludes ack delays where the largest ack references an

PR #1611 sent

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1574#discussion_r206132089