Re: [quicwg/base-drafts] Unified ACK frame (#1706)

Magnus Westerlund <notifications@github.com> Fri, 14 September 2018 11:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 47733130E26 for <quic-issues@ietfa.amsl.com>; Fri, 14 Sep 2018 04:20:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R-RmvghYEtgS for <quic-issues@ietfa.amsl.com>; Fri, 14 Sep 2018 04:20:14 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B3C0126DBF for <quic-issues@ietf.org>; Fri, 14 Sep 2018 04:20:14 -0700 (PDT)
Date: Fri, 14 Sep 2018 04:20:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1536924013; bh=Q00Ee2cbKlU/6WhgKAbynI164ULPgYEVfe4bpIt1wXI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oVD1gQ184PgXQHXoHkdb1dcmxE4qBnrKxOXIPuk65qiAnDHyy/jOejUt32A6UzMku VAkc3Ecrmq7j4+8sK+vY9eRAWCYhLOgcDVAxkq4p/rrIEo8HSxpWes/mUbRFbJoaEv b1SOSW/4CMe9fYh2rm8qX19YtkUcEJgeVTkP/sF4=
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf1fc0c3b2ce3ec428835f7ed1f55b80a095a5cea92cf0000000117b35b6d92a169ce151d0067@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1706/c421328718@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1706@github.com>
References: <quicwg/base-drafts/pull/1706@github.com>
Subject: Re: [quicwg/base-drafts] Unified ACK frame (#1706)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b9b996daec08_2643fcb60cd45b8227742"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1a4jDRHlsRbjWh_6BoQlShIAyNI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Sep 2018 11:20:16 -0000

So based on the discussion and my further analysis I think we should not adopt this pull request. I think counters are the best option, and I am fine with optimizing their representation as it will definitely save a number of bytes per ACK for long lived connections.  

When it comes to marking in this one. I think unless one have an explicit mechanism for sender to signal to receiver which ECT codepoints that are the one used then having one ECT(any) would be the better choice. Using both ECT codepoints needs additional extensions as some of the experiments with marking, like L4S does mean that packets marked with different ECT values sees different paths. Thus, there need to be mechanisms in place to handle this. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1706#issuecomment-421328718