Re: [quicwg/base-drafts] use a HANDSHAKE_DONE frame to drive the handshake to confirmation (#3145)
Martin Thomson <notifications@github.com> Wed, 11 December 2019 05:53 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2424120133 for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 21:53:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Calc_FhkX5WG for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 21:53:10 -0800 (PST)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4CFEC12002F for <quic-issues@ietf.org>; Tue, 10 Dec 2019 21:53:10 -0800 (PST)
Date: Tue, 10 Dec 2019 21:53:09 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1576043589; bh=xSmsTyzW2bwhKJh1opyNxQiNn2pbkl7ntfq9GOSGYYU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iyltncUswHL4iCnYYaU1e5OAoN6xIP20wpUUY1gJjJRkCMeaWPP8rTcxYhl7ImXbG oceF8qr89qEDljRk4ayjpwLIxuHRgeLt6hHJWH/tkTy1+27oQF/uV5Kee74QdS8/5e iuOaCgGlJG5IV3QKyuV9nIEXZKuzfeceYXlrl/EQ=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6CUK2YUBC7CUHA7I537W3MLEVBNHHB475TUU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3145/review/330311127@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3145@github.com>
References: <quicwg/base-drafts/pull/3145@github.com>
Subject: Re: [quicwg/base-drafts] use a HANDSHAKE_DONE frame to drive the handshake to confirmation (#3145)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5df084456cdd1_736d3ff2dd2cd96c10011f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1pn3wjlvkB5pDnXSFf7iGGfV3w4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 05:53:12 -0000
martinthomson commented on this pull request. > +## HANDSHAKE_DONE frame {#handshake-done-frame} + +The server uses the HANDSHAKE_DONE frame (type=0x1e) to signal confirmation of +the handshake to the client. The HANDSHAKE_DONE frame contains no additional +fields. + +This frame can only be sent by the server. Servers MUST NOT send a +HANDSHAKE_DONE frame before completing the handshake. A server MUST treat +receipt of a HANDSHAKE_DONE frame as a connection error of type +PROTOCOL_VIOLATION. + +A client MAY consider the handshake to be confirmed when it receives an +acknowledgement for a 1-RTT packet. This can be implemented by recording +the lowest packet number sent with 1-RTT keys, and the highest value of the +Largest Acknowledged field in any received 1-RTT ACK frame: once the latter is +higher than or equal to the former, the handshake can be confirmed. Gah. I had the same thought before but failed to write it down. Thanks for catching that. I'll open a PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3145#discussion_r356413912
- [quicwg/base-drafts] use a HANDSHAKE_DONE frame t… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Christian Huitema
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Christian Huitema