Re: [quicwg/base-drafts] Added more test to NCID section (#3535)

Martin Thomson <> Fri, 20 March 2020 00:14 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id CE2E83A12E7 for <>; Thu, 19 Mar 2020 17:14:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -1.695
X-Spam-Status: No, score=-1.695 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id sY2msCoEbO-q for <>; Thu, 19 Mar 2020 17:14:39 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 02A493A1048 for <>; Thu, 19 Mar 2020 17:13:56 -0700 (PDT)
Date: Thu, 19 Mar 2020 17:13:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1584663234; bh=3yg/wfGLDH5Li1pePiyy3JAuw6gMlrSFg/HCzvxccUY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iElbX0+hsQ+caCX542+nsAM3OJFtXF693F6RrArMwuIZ7X3+ReT87K5REdZq/ze9u hIib1h7ptN6cfZNjbdvcSuGW1O7d0pZ1+hkd5htlg+ROLKhrgm4WOOu5SAb0wGU1k/ +aRyV3rTedrcKHf0xVjKJmus/DA0b3lMqYpSSvE0=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3535/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Added more test to NCID section (#3535)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e740ac23966c_2c103fc1014cd9644414f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 20 Mar 2020 00:14:46 -0000

martinthomson commented on this pull request.

> @@ -5579,8 +5585,8 @@ value.
 An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
 smaller than the Retire Prior To field of a previously received
 NEW_CONNECTION_ID frame MUST immediately send a corresponding
-RETIRE_CONNECTION_ID frame that retires the newly received connection ID.
+RETIRE_CONNECTION_ID frame that retires the newly received connection ID,
+unless it has already done so for that sequence number.

I would also lose the "immediately".  That's not a useful word to use in this context.

> @@ -5571,6 +5571,12 @@ Retire Prior To field MUST be less than or equal to the Sequence Number field.
 Receiving a value greater than the Sequence Number MUST be treated as a
 connection error of type FRAME_ENCODING_ERROR.
+Endpoints that receive a NEW_CONNECTION_ID frame SHOULD NOT retire connection
+IDs with a sequence number equal to or greater than the Retire Prior To field
+solely as a result of receiving the frame. If the peer is trying to maintain a
+stock of provided CIDs, this can result in an infinite loop of

I don't think that we need this paragraph.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: