Re: [quicwg/base-drafts] Extension frames and congestion/flow control (#1811)
Lucas Pardue <notifications@github.com> Fri, 28 September 2018 10:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CCDB130E00 for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 03:38:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c-62bo8-a-S7 for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 03:38:41 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C403130DFE for <quic-issues@ietf.org>; Fri, 28 Sep 2018 03:38:41 -0700 (PDT)
Date: Fri, 28 Sep 2018 03:38:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538131120; bh=a5+nLnZyNSHxTrvTatW5c6F3mMzb/rxYuvwZJobkbJM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pYfuoxj+l4HI7+CTdAJd43vWflJXM13c4/LeC2LXJ82U73gC0ZRiTBDVvVZkbOT/G rCiFrKFNS1BloNo0Dy22QXp1+TVzeG9EfiiqbPtXXdmYnfUi2LqEOw+7A1QqkjN9C3 N8D9N4Y3NLEqRAvrAcNYzoxk87IxS0bu5gUadEvw=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab02b9c4e4e9340cb50c0038895324798d00e80e4292cf0000000117c5c6b092a169ce15bedb09@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1811/review/159806844@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1811@github.com>
References: <quicwg/base-drafts/pull/1811@github.com>
Subject: Re: [quicwg/base-drafts] Extension frames and congestion/flow control (#1811)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bae04b06ac57_1d83faaeaed45c02014b2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/201HA0H8K9R0ascuopFXOqru7tI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 10:38:43 -0000
LPardue commented on this pull request. > @@ -1199,6 +1199,11 @@ that a peer is able to understand the frame. An endpoint can use a transport parameter to signal its willingness to receive one or more extension frame types with the one transport parameter. +Extension frames MUST be contestion controlled and MUST cause an ACK frame to +be sent. The exception is extension frames that replace or supplement the ACK +frame. Extension frames are not included in flow control unless specifically +specified in the extension. Specifically specified can probably be reduced to just specified -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1811#pullrequestreview-159806844
- [quicwg/base-drafts] Extension frames and congest… ianswett
- Re: [quicwg/base-drafts] Extension frames and con… MikkelFJ
- Re: [quicwg/base-drafts] Extension frames and con… Lucas Pardue
- Re: [quicwg/base-drafts] Extension frames and con… ianswett
- Re: [quicwg/base-drafts] Extension frames and con… Martin Thomson
- Re: [quicwg/base-drafts] Extension frames and con… Rui Paulo
- Re: [quicwg/base-drafts] Extension frames and con… ianswett
- Re: [quicwg/base-drafts] Extension frames and con… Rui Paulo
- Re: [quicwg/base-drafts] Extension frames and con… Mike Bishop
- Re: [quicwg/base-drafts] Extension frames and con… ianswett
- Re: [quicwg/base-drafts] Extension frames and con… MikkelFJ
- Re: [quicwg/base-drafts] Extension frames and con… ianswett
- Re: [quicwg/base-drafts] Extension frames and con… Rui Paulo