Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)

Martin Thomson <notifications@github.com> Thu, 20 August 2020 00:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6275F3A0FBB for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 17:24:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wpaidVCxXwWD for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 17:24:24 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEC563A0FB9 for <quic-issues@ietf.org>; Wed, 19 Aug 2020 17:24:23 -0700 (PDT)
Received: from github-lowworker-b2150d3.ash1-iad.github.net (github-lowworker-b2150d3.ash1-iad.github.net [10.56.113.12]) by smtp.github.com (Postfix) with ESMTP id 190C55E0069 for <quic-issues@ietf.org>; Wed, 19 Aug 2020 17:24:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597883063; bh=OeUtYk59oWKBHzdOpO4+98ghqgHEzjWtvF9Wj0DWve4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HQ4hb+NyqKBNdYuKOb60FGMJQZrk1U6bdyOzaUPAFOLD6Y4ehTmSRInlhh90+AoUc PwC/CTb7SJa5ZXM+1Q9fvbmCru2darj2Fy+THcF3vsnyRmL7LN/QvyuCD5ivO8Pcar 3Fj/9RzFyF3JuUmUSs5nOiw/HuNSnYwtsEVCMquU=
Date: Wed, 19 Aug 2020 17:24:23 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2GXVMKAZM4GKUGISV5JGR3PEVBNHHCRJE2U4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4016/review/471048275@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4016@github.com>
References: <quicwg/base-drafts/pull/4016@github.com>
Subject: Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3dc2b77e31_505e19641021ed"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/21qGztV8NcH_P42i8JHzKokLahQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 00:24:25 -0000

@martinthomson requested changes on this pull request.

What Mike said applies also.

> +port reuse. An endpoint MUST NOT use an IP address and port pair for multiple
+connections unless it is certain that those protocol features are not in use.

This misses the zero-length connection ID qualification, which is the key point.

> @@ -1232,7 +1232,9 @@ cannot be reverted.
 Valid packets sent to clients always include a Destination Connection ID that
 matches a value the client selects.  Clients that choose to receive
 zero-length connection IDs can use the local address and port to identify a
-connection.  Packets that do not match an existing connection are discarded.
+connection.  Packets that do not match an existing connection, based on
+Destination Connection ID or, if zero-length, local IP address and port,

```suggestion
Destination Connection ID or, if this value zero-length, local IP address and port,
```

> +The definition of new transport parameters ({{new-transport-parameters}}) is
+REQUIRED to specify whether they MUST, MAY, or MUST NOT be stored for 0-RTT. A

Also, MUST > REQUIRED.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4016#pullrequestreview-471048275