Re: [quicwg/base-drafts] Change Index-Duplicate instruction code point (#1235)
Mike Bishop <notifications@github.com> Tue, 20 March 2018 11:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD9A9126DC2 for <quic-issues@ietfa.amsl.com>; Tue, 20 Mar 2018 04:34:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.009
X-Spam-Level:
X-Spam-Status: No, score=-7.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eZFY9d3YDTpZ for <quic-issues@ietfa.amsl.com>; Tue, 20 Mar 2018 04:33:59 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F6DC126DED for <quic-issues@ietf.org>; Tue, 20 Mar 2018 04:33:45 -0700 (PDT)
Date: Tue, 20 Mar 2018 04:33:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521545624; bh=Jw5dOKr2kOfUrrQTx/mcIaacM2p7PHepeU8mPUjC1ew=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=2TGuGrn2OOSm4ZfpJDiBjrhU3uDBYBvm9qj4GLSH5jzbdCliqs+bIzR9rJl8l3W1M a9eH65DAiBJqCysOqxr+zaYaCwmqVU448iezWxYdI5dPkWPUQiWzGK8HOzhGQ0X2ik ufburnsKZ4LQBHxQ56gxcmACC8nmEOfI/D0HWDDM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab928a5f8273a0c6fd22e6e52cac4796cc2f109d3892cf0000000116c8b39892a169ce12443200@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1235/review/105308786@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1235@github.com>
References: <quicwg/base-drafts/pull/1235@github.com>
Subject: Re: [quicwg/base-drafts] Change Index-Duplicate instruction code point (#1235)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ab0f198de7d5_58363faadfc12f2c335082"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/22tgWr12h_AbmwE8NEvA_JujLkA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 11:34:01 -0000
MikeBishop commented on this pull request.
> @@ -253,7 +253,7 @@ Indexed-Duplicate representation instead (see {{indexed-duplicate}}).
~~~~~~~~~~ drawing
0 1 2 3 4 5 6 7
+-+-+-+-+-+-+-+-+
- |0|0|1|Index(5+)|
+ |1|Index(7+) |
Center, and probably a space before the parenthesis since there's room.
> @@ -262,8 +262,8 @@ Indexed-Duplicate representation instead (see {{indexed-duplicate}}).
an existing entry. {{RFC7541}} allows duplicate HPACK table entries, that is
entries that have the same name and value.
-This replaces the HPACK instruction for Dynamic Table Size Update (see Section
-6.3 of {{RFC7541}}, which is not supported by HTTP over QUIC.
+This repurposes the HPACK instruction for Indexed Header Field (see Section
+6.1 of {{RFC7541}}.
This wording might be confusing to some readers. It might be more accurate to say that you're defining the behavior of this instruction on the control stream, while it retains its usual meaning on the request streams.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1235#pullrequestreview-105308786