Re: [quicwg/base-drafts] MUST pace or limit bursts to 10 packets (#3106)

ianswett <notifications@github.com> Fri, 25 October 2019 16:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C861120976 for <quic-issues@ietfa.amsl.com>; Fri, 25 Oct 2019 09:55:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RIMFQlQ8TA6V for <quic-issues@ietfa.amsl.com>; Fri, 25 Oct 2019 09:55:15 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D06AA12098B for <quic-issues@ietf.org>; Fri, 25 Oct 2019 09:55:14 -0700 (PDT)
Date: Fri, 25 Oct 2019 09:55:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572022513; bh=ewjuC2hhIob0eCucsr2kfvgxobFC9vtRiyMFTIsxQyU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=2HWKcgW/EIV9i1WISTNhEOV9K718oqo/x5/6E9IhjVr4zlHLbsYNcNDtoRz9IlMwb SL6RCjVTCbjbvLGXyiPV0poSR4tfP4jfEVTUs0PsOmKwUl1To+GoHDzp5dXwbWb/R/ swvYUY1GF4bX+6TnHTfGQ7SpQf1sc7rRM+A1EXQU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK546RSIUOX44B5POPV3YBUYDEVBNHHB4SPHCQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3106/review/307330567@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3106@github.com>
References: <quicwg/base-drafts/pull/3106@github.com>
Subject: Re: [quicwg/base-drafts] MUST pace or limit bursts to 10 packets (#3106)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db328f1de898_6cf63ffb52acd964946fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/24uRD0u4TZKh9V7ee1iRB1nD5EA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2019 16:55:16 -0000

ianswett commented on this pull request.



> @@ -753,6 +753,12 @@ delivery of ACK frames is important for efficient loss recovery. Packets
 containing only ACK frames should therefore not be paced, to avoid delaying
 their delivery to the peer.
 
+Sending multiple packets into the network without any delay between them
+creates a packet burst that might cause short-term congestion and losses.
+Implementations MUST either use pacing or limit such bursts to minimum
+of 10 * kMaxDatagramSize and max(2* kMaxDatagramSize, 14720)), the same
+as the recommended initial congestion window.
+

That's a good point.  We could swap the sentence and say "same as the initial congestion window, which is recommended to be ..." if you think it's preferable.  But I'm also not sure it matters much.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3106#discussion_r339146939